public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 16/18] test: py: Add a test for log filter-*
Date: Tue,  6 Oct 2020 15:16:08 -0400	[thread overview]
Message-ID: <20201006191610.761899-17-seanga2@gmail.com> (raw)
In-Reply-To: <20201006191610.761899-1-seanga2@gmail.com>

This exercises a few success and failure modes of the log filter-*
commands.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

 test/py/tests/test_log.py | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/test/py/tests/test_log.py b/test/py/tests/test_log.py
index f191c84c02..87c0c21575 100644
--- a/test/py/tests/test_log.py
+++ b/test/py/tests/test_log.py
@@ -154,3 +154,42 @@ def test_log_format(u_boot_console):
         run_with_format('FLfm', 'file.c:123-func() msg')
         run_with_format('lm', 'NOTICE. msg')
         run_with_format('m', 'msg')
+
+ at pytest.mark.buildconfigspec('cmd_log')
+def test_log_filter(u_boot_console):
+    c = u_boot_console
+
+    # Test invalid options
+    assert 'rc:1' in c.run_command('log filter-add -AD; echo rc:$?')
+    assert 'rc:1' in c.run_command('log filter-add -l1 -L1; echo rc:$?')
+    assert 'rc:1' in c.run_command('log filter-add -l1 -L1; echo rc:$?')
+    assert 'rc:1' in c.run_command('log filter-add -lfoo; echo rc:$?')
+    assert 'rc:1' in c.run_command('log filter-add -cfoo; echo rc:$?')
+    assert 'rc:1' in c.run_command('log filter-add -ccore -ccore -ccore -ccore -ccore -ccore; echo rc:$?')
+
+    # Test filters
+    assert c.run_command('log format m') == ''
+    filt1 = c.run_command('log filter-add -p')
+    assert c.run_command('log rec mmc warning file 123 func msg') == 'msg'
+    filt2 = c.run_command('log filter-add -p -DL warning -cmmc -cspi -ffile')
+    assert c.run_command('log rec mmc warning file 123 func msg') == ''
+    assert c.run_command('log rec spi warning file 123 func msg') == ''
+    assert c.run_command('log rec arch warning file 123 func msg') == 'msg'
+    assert c.run_command('log rec mmc warning file2 123 func msg') == 'msg'
+    assert c.run_command('log rec mmc err file 123 func msg') == 'msg'
+
+    # "Test" filter-list; ignore the header
+    resp = c.run_command('log filter-list')[:-1]
+    assert filt1 in resp
+    assert filt2 in resp
+    assert 'allow' in resp
+    assert 'deny' in resp
+    assert '>=WARNING' in resp
+    assert '<=IO' in resp
+    assert 'mmc' in resp
+    assert 'spi' in resp
+    assert 'file' in resp
+
+    # Ensure removal works
+    assert c.run_command('log filter-remove ' + filt2) == ''
+    assert c.run_command('log rec mmc warning file 123 func msg') == 'msg'
-- 
2.28.0

  parent reply	other threads:[~2020-10-06 19:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 19:15 [PATCH 00/18] log: Add commands for manipulating filters Sean Anderson
2020-10-06 19:15 ` [PATCH 01/18] log: Fix missing negation of ENOMEM Sean Anderson
2020-10-06 20:36   ` Heinrich Schuchardt
2020-10-06 19:15 ` [PATCH 02/18] log: Fix incorrect documentation of log_filter.cat_list Sean Anderson
2020-10-06 20:41   ` Heinrich Schuchardt
2020-10-06 19:15 ` [PATCH 03/18] log: Add new category names to log_cat_name Sean Anderson
2020-10-06 20:45   ` Heinrich Schuchardt
2020-10-06 19:15 ` [PATCH 04/18] log: Use CONFIG_IS_ENABLED() for LOG_TEST Sean Anderson
2020-10-06 19:15 ` [PATCH 05/18] log: Expose log_device_find_by_name Sean Anderson
2020-10-06 19:15 ` [PATCH 06/18] log: Add function to create a filter with flags Sean Anderson
2020-10-06 19:15 ` [PATCH 07/18] log: Add filter flag to deny on match Sean Anderson
2020-10-06 19:16 ` [PATCH 08/18] test: Add tests for LOGFF_DENY Sean Anderson
2020-10-06 19:16 ` [PATCH 09/18] log: Add filter flag to match greater than a log level Sean Anderson
2020-10-06 19:16 ` [PATCH 10/18] test: Add test for LOGFF_MIN Sean Anderson
2020-10-06 19:16 ` [PATCH 11/18] cmd: log: Use sub-commands for log Sean Anderson
2020-10-06 19:16 ` [PATCH 12/18] cmd: log: Split off log level parsing Sean Anderson
2020-10-06 19:16 ` [PATCH 13/18] lib: Add getopt Sean Anderson
2020-10-06 19:16 ` [PATCH 14/18] test: Add a test for getopt Sean Anderson
2020-10-06 19:16 ` [PATCH 15/18] cmd: log: Add commands to manipulate filters Sean Anderson
2020-10-06 21:14   ` Heinrich Schuchardt
2020-10-06 21:51     ` Sean Anderson
2020-10-06 22:02   ` Simon Glass
2020-10-06 22:04     ` Sean Anderson
2020-10-06 19:16 ` Sean Anderson [this message]
2020-10-06 22:07   ` [PATCH 16/18] test: py: Add a test for log filter-* Simon Glass
2020-10-06 22:09     ` Sean Anderson
2020-10-06 19:16 ` [PATCH 17/18] doc: Add log kerneldocs to documentation Sean Anderson
2020-10-06 19:16 ` [PATCH 18/18] doc: Update logging documentation Sean Anderson
2020-10-06 20:34   ` Heinrich Schuchardt
2020-10-06 20:38     ` Sean Anderson
2020-10-06 21:28       ` Heinrich Schuchardt
2020-10-06 22:00         ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006191610.761899-17-seanga2@gmail.com \
    --to=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox