public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV
Date: Wed, 7 Oct 2020 07:11:43 -0500	[thread overview]
Message-ID: <20201007121143.gkyvzcfms2e6pczb@deranged> (raw)
In-Reply-To: <c772bcf8-f82a-fe3e-5f2b-92268c20dfde@ti.com>

On 11:15-20201007, Lokesh Vutla wrote:
> 
> 
> On 07/10/20 12:35 am, Nishanth Menon wrote:
> > Use the common defaults from ./include/configs/ti_armv7_common.h
> > 
> > This saves us from rediscovering the same painful lessons learnt from
> > ARMv7 (kernel dtbs ramdisks overlays stomping on each other etc..)
> 
> If PATCH 3 is made as PATCH 1, then existing PATCH (1&4) and  PATCH (2&5) can be
> combined.


Does'nt that break bisectability?
include/environment/ti/ufs.h defines DEFAULT_UFS_TI_ARGS using
overlayaddr, include/configs/j721e_evm.h uses that macro in
CONFIG_EXTRA_ENV_SETTINGS, if I move patch 3 as patch 1, dtboaddr is not
defined since DEFAULT_LINUX_BOOT_ENV is not yet included..

I know that am654 probably does'nt use DEFAULT_UFS_TI_ARGS, but it
looked elegant to clean it up in stages together.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2020-10-07 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 19:05 [PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV Nishanth Menon
2020-10-06 19:05 ` [PATCH 1/5] configs: am65x_evm: " Nishanth Menon
2020-10-06 19:05 ` [PATCH 2/5] configs: j721e_evm: " Nishanth Menon
2020-10-06 19:05 ` [PATCH 3/5] env: ti: ufs: Use dtboaddr instead of overlayaddr Nishanth Menon
2020-10-06 19:05 ` [PATCH 4/5] configs: am65x_evm: Get rid " Nishanth Menon
2020-10-06 19:05 ` [PATCH 5/5] configs: j721e_evm: " Nishanth Menon
2020-10-07  5:45 ` [PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV Lokesh Vutla
2020-10-07 12:11   ` Nishanth Menon [this message]
2020-10-08  2:51     ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007121143.gkyvzcfms2e6pczb@deranged \
    --to=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox