public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [fs/squashfs PATCH v3 1/2] Add warning for dynamic memory usage.
Date: Thu, 8 Oct 2020 09:28:03 +0200	[thread overview]
Message-ID: <20201008092803.7c43fc24@xps13> (raw)
In-Reply-To: <20201007223021.2443619-2-mc5686@mclink.it>

Hi Mauro,

Mauro Condarelli <mc5686@mclink.it> wrote on Thu,  8 Oct 2020 00:30:20
+0200:

> SquashFS may need a large amount of dynamic memory fot its buffers,
> especially if and when compression is enabled I got failures with
> CONFIG_SYS_MALLOC_LEN < 0x4000.
> 
> I found no way to enforce this in Kconfig itself, so I resorted
> to ada a warning in help string.

Nit: s/ada/add/ s/in help/in the help/?

Besides that,

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> 
> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
> ---
> 
> (no changes since v1)
> 
>  fs/squashfs/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/squashfs/Kconfig b/fs/squashfs/Kconfig
> index 54ab1618f1..7c3f83d007 100644
> --- a/fs/squashfs/Kconfig
> +++ b/fs/squashfs/Kconfig
> @@ -9,3 +9,5 @@ config FS_SQUASHFS
>  	  filesystem use, for archival use (i.e. in cases where a .tar.gz file
>  	  may be used), and in constrained block device/memory systems (e.g.
>  	  embedded systems) where low overhead is needed.
> +	  WARNING: if compression is enabled SquashFS needs a large amount
> +	  of dynamic memory; make sure CONFIG_SYS_MALLOC_LEN >= 0x4000.

Thanks,
Miqu?l

  reply	other threads:[~2020-10-08  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 22:30 [fs/squashfs PATCH v3 0/2] fs/squashfs: avoid 64-bit divisions on 32-bit Mauro Condarelli
2020-10-07 22:30 ` [fs/squashfs PATCH v3 1/2] Add warning for dynamic memory usage Mauro Condarelli
2020-10-08  7:28   ` Miquel Raynal [this message]
2020-10-07 22:30 ` [fs/squashfs PATCH v3 2/2] avoid 64-bit divisions on 32-bit Mauro Condarelli
2020-10-08  7:34   ` Miquel Raynal
2020-10-08  8:15     ` Mauro Condarelli
2020-10-08  7:42   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008092803.7c43fc24@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox