* [PATCH] spl: Avoid printing boot device if silent console is enabled
@ 2020-09-03 17:25 Otavio Salvador
2020-09-03 18:10 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Otavio Salvador @ 2020-09-03 17:25 UTC (permalink / raw)
To: u-boot
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
common/spl/spl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index 4840d1d367..63c48fbf33 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image,
struct spl_image_loader *loader;
loader = spl_ll_find_loader(spl_boot_list[i]);
-#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
+#if defined(CONFIG_SPL_SERIAL_SUPPORT) \
+ && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) \
+ && !defined(CONFIG_SILENT_CONSOLE)
if (loader)
printf("Trying to boot from %s\n", loader->name);
else
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] spl: Avoid printing boot device if silent console is enabled
2020-09-03 17:25 [PATCH] spl: Avoid printing boot device if silent console is enabled Otavio Salvador
@ 2020-09-03 18:10 ` Tom Rini
2020-09-04 4:47 ` Stefan Roese
2020-10-14 17:42 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-09-03 18:10 UTC (permalink / raw)
To: u-boot
On Thu, Sep 03, 2020 at 02:25:15PM -0300, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200903/089e1867/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] spl: Avoid printing boot device if silent console is enabled
2020-09-03 17:25 [PATCH] spl: Avoid printing boot device if silent console is enabled Otavio Salvador
2020-09-03 18:10 ` Tom Rini
@ 2020-09-04 4:47 ` Stefan Roese
2020-10-14 17:42 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2020-09-04 4:47 UTC (permalink / raw)
To: u-boot
On 03.09.20 19:25, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> common/spl/spl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 4840d1d367..63c48fbf33 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image,
> struct spl_image_loader *loader;
>
> loader = spl_ll_find_loader(spl_boot_list[i]);
> -#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> +#if defined(CONFIG_SPL_SERIAL_SUPPORT) \
> + && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) \
> + && !defined(CONFIG_SILENT_CONSOLE)
Nitpicking:
I think its preferred to put the "&&" (or "||") at the end of the line.
Other than that:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] spl: Avoid printing boot device if silent console is enabled
2020-09-03 17:25 [PATCH] spl: Avoid printing boot device if silent console is enabled Otavio Salvador
2020-09-03 18:10 ` Tom Rini
2020-09-04 4:47 ` Stefan Roese
@ 2020-10-14 17:42 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-10-14 17:42 UTC (permalink / raw)
To: u-boot
On Thu, Sep 03, 2020 at 02:25:15PM -0300, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201014/f755253d/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-14 17:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03 17:25 [PATCH] spl: Avoid printing boot device if silent console is enabled Otavio Salvador
2020-09-03 18:10 ` Tom Rini
2020-09-04 4:47 ` Stefan Roese
2020-10-14 17:42 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox