From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 14 Oct 2020 15:31:13 -0400 Subject: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce() In-Reply-To: References: <20201006203951.18040-1-alpernebiyasak@gmail.com> <469bd776-c20a-32c7-ad8d-32adb5b378c7@gmail.com> <20201014152433.GV14816@bill-the-cat> Message-ID: <20201014193113.GS14816@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: > On 14/10/2020 18:24, Tom Rini wrote: > > On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: > >> I think it is OK to change the file to GPL2. I'm not sure if changing > >> coreboot parts to 2.0+ is an option. I believe the use of 2+ in U-Boot > >> is for fairly narrow reasons, but I'm not sure if that is documented > >> anywhere. > >> > >> +Tom Rini might have a comment > > > > Ugh. In so far as anything can be re-licensed, who did it all > > originally? I suspect coreboot isn't interested in 2.0+ but we can do > > 2.0-only. > > For this patch, coreboot commit b9a7877568cf ("rockchip/*: refactor edp > driver") introduces the related change to src/soc/rockchip/common/edp.c > renamed from .../rk3288/edp.c, which was introduced at coreboot commit > 40f558e8f4f7 ("rockchip: support display"). > > $ git shortlog -s -e b9a7877568cf -- src/soc/rockchip/{common,rk3288}/edp.c > > 2 Julius Werner > > 1 Lin Huang > > 1 Patrick Georgi > > 1 Patrick Georgi > > 4 huang lin > > The sign-offs are: > > $ git log b9a7877568cf -- src/soc/rockchip/{common,rk3288}/edp.c \ > | grep -i "Signed-off-by:" | sort -u > > Original-Signed-off-by: huang lin > > Original-Signed-off-by: Julius Werner > > Original-Signed-off-by: Lin Huang > > Signed-off-by: Patrick Georgi > > Signed-off-by: Stefan Reinauer > > That file at that refactor-commit has two more fixes I'm interested in, > and it's not the only file things could be ported from. If I run the > above on a wider list of files upto current master I get 16 authors or > 20 signoffs with duplicates (including e.g. original-signed-off-by), > most of them either @google.com, @chromium.org, or @rock-chips.com. > > $ git shortlog -s -e -- src/soc/rockchip/{common,rk3288,rk3399}/{include/soc/,include/,}{edp,vop,display,mipi}{.c,.h} > > 1 Angel Pons > > 1 Arthur Heymans > > 3 David Hendricks > > 1 Ege Mihmanli > > 15 Elyes HAOUAS > > 1 Jacob Garber > > 7 Julius Werner > > 1 Ky?sti M?lkki > > 13 Lin Huang > > 1 Martin Roth > > 2 Nickey Yang > > 1 Patrick Georgi > > 3 Patrick Georgi > > 2 Shunqian Zheng > > 2 Yakir Yang > > 5 huang lin > > $ git log -- src/soc/rockchip/{common,rk3288,rk3399}/{include/soc/,include/,}{edp,vop,display,mipi}{.c,.h} \ > | grep -i "Signed-off-by:" | sort -u > > Original-Signed-off-by: David Hendricks > > Original-Signed-off-by: huang lin > > Original-Signed-off-by: Julius Werner > > Original-Signed-off-by: Lin Huang > > Original-Signed-off-by: Shunqian Zheng > > Original-Signed-off-by: Yakir Yang > > Signed-off-by: Angel Pons > > Signed-off-by: Arthur Heymans > > Signed-off-by: Ege Mihmanli > > Signed-off-by: Elyes HAOUAS > > Signed-off-by: Jacob Garber > > Signed-off-by: Julius Werner > > Signed-off-by: Ky?sti M?lkki > > Signed-off-by: Lin Huang > > Signed-off-by: Martin Roth > > Signed-off-by: Nickey Yang > > Signed-off-by: Patrick Georgi > > Signed-off-by: Patrick Georgi > > Signed-off-by: Patrick Georgi > > Signed-off-by: Stefan Reinauer > > (There's also hdmi{.c,.h} licensed w/ GPL-2.0-or-later, and clock{.c,.h} > for which the U-Boot counterpart is already "GPL-2.0" assuming thats > GPL-2.0-only, so I've excluded both.) Right, sorry. I mean, on the U-Boot side, where did things come from? I wonder how we got a different license text, and perhaps if we shouldn't just re-port the coreboot code over as a clean/clear way to re-license it to GPL-2.0-only. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: