[PATCH 15/17] fs/squashfs: sqfs_read: fix memory leak

Richard Genoud
2020-10-16T14:49:31Z

Le 14/10/2020 ? 10:06, Richard Genoud a ?crit?:
> sqfs_closedir() should be called to free memory allocated by
> sqfs_opendir()
>
> Signed-off-by: Richard Genoud <richard.genoud@posteo.net>
> ---
> fs/squashfs/sqfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
> index 79d68dddb28..6cd3ba9ce10 100644
> --- a/fs/squashfs/sqfs.c
> +++ b/fs/squashfs/sqfs.c
> @@ -1531,6 +1531,7 @@ free_datablk:
> free_paths:
> free(file);
> free(dir);
> + sqfs_closedir(dirsp);

I forgot to remove a sqfs_closedir(dirsp); at the begining of the sqfs_read() function.
So this could lead to a double free.
I'll add it in next version.

>
> return ret;
> }
>