[PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

[Tom Rini <trini@konsulko.com>]

On Wed, Oct 14, 2020 at 11:39:40PM +0300, Alper Nebi Yasak wrote:
> On 14/10/2020 22:31, Tom Rini wrote:
> > On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote:
> >> On 14/10/2020 18:24, Tom Rini wrote:
> >>> Ugh.  In so far as anything can be re-licensed, who did it all
> >>> originally?  I suspect coreboot isn't interested in 2.0+ but we can do
> >>> 2.0-only.
> >>
> >> For this patch, coreboot commit b9a7877568cf ("rockchip/*: refactor edp
> >> driver") introduces the related change to src/soc/rockchip/common/edp.c
> >> renamed from .../rk3288/edp.c, which was introduced at coreboot commit
> >> 40f558e8f4f7 ("rockchip: support display").
> > 
> > Right, sorry.  I mean, on the U-Boot side, where did things come from?
> > I wonder how we got a different license text, and perhaps if we
> > shouldn't just re-port the coreboot code over as a clean/clear way to
> > re-license it to GPL-2.0-only.
> 
> I'm not sure re-porting is a great idea from the technical perspective.
> I've been reading both drivers to compare them, there are also things in
> U-Boot that're missing from coreboot. Things like DM integration are
> also not there as they're U-Boot specific.
> 
> I checked some files with git log and checked the first commit that
> showed up for each.
> 
> Simon Glass <sjg@chromium.org> added:
> - drivers/video/rockchip/rk_edp.c
> - drivers/video/rockchip/rk_hdmi.c
> - drivers/video/rockchip/rk_vop.c
> - arch/arm/include/asm/arch-rockchip/vop_rk3288.h
> - arch/arm/include/asm/arch-rockchip/edp_rk3288.h
> as Copyright (c) 2015 Google, Inc
>    Copyright 2014 Rockchip Inc.
> 
> Philipp Tomsich <philipp.tomsich@theobroma-systems.com> added:
> - drivers/video/rockchip/rk3288_hdmi.c
> - drivers/video/rockchip/rk3399_hdmi.c
> - drivers/video/rockchip/rk_hdmi.h
> - drivers/video/rockchip/rk_vop.h
> as Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH
> - drivers/video/rockchip/rk3288_vop.c
> - drivers/video/rockchip/rk3399_vop.c
> as Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH
>    Copyright (c) 2015 Google, Inc
>    Copyright 2014 Rockchip Inc.
> 
> Eric Gao <eric.gao@rock-chips.com> added:
> - drivers/video/rockchip/rk3288_mipi.c
> - drivers/video/rockchip/rk3399_mipi.c
> - drivers/video/rockchip/rk_mipi.c
> - drivers/video/rockchip/rk_mipi.h
> - arch/arm/include/asm/arch-rockchip/rockchip_mipi_dsi.h
> as Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
> 
> Jacob Chen <jacob-chen@iotwrt.com> added:
> - drivers/video/rockchip/rk_lvds.c
> - arch/arm/include/asm/arch-rockchip/lvds_rk3288.h
> as Copyright 2016 Rockchip Inc.

Probably then the best "I am not a lawyer" answer is to have Philipp
Tomsich, Eric Gao and Jacob Chen all acked-by a patch to mark our driver
as GPL-2.0-only so that it's very clear that we can take improvements
from other GPL-2.0-only sources.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201015/d7c8335e/attachment.sig>