From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Fri, 16 Oct 2020 14:34:27 +0200
Subject: [PATCH 06/17] fs/squashfs: sqfs_read_directory_table: fix
 memory leak
In-Reply-To: <550f42e5-0d29-c8b1-0777-49d41e50f629@posteo.net>
References: <20201014080622.14970-1-richard.genoud@posteo.net>
 <20201014080622.14970-7-richard.genoud@posteo.net>
 <20201015155412.2830559d@xps13>
 <6d4eecef-5d8f-37a2-a1df-1103aaab52d5@posteo.net>
 <20201015183851.01e8082f@xps13>
 <550f42e5-0d29-c8b1-0777-49d41e50f629@posteo.net>
Message-ID: <20201016143427.7292c5dd@xps13>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Richard,

Richard Genoud <richard.genoud@posteo.net> wrote on Fri, 16 Oct 2020
14:31:53 +0200:

> Le 15/10/2020 ? 18:38, Miquel Raynal a ?crit?:
> > Hi Richard,  
> 
> >> That's why I prefer only one label and setting NULL.
> >> If I didn't convince you, I'll change it back to multiple labels :)  
> > 
> > You are right it involves less changes when editing the code. But
> > on the other hand it is so often written like [my proposal], that it
> > almost becomes a coding style choice I guess. Anyway, I don't have a
> > strong opinion on this so I'll let you choose the best approach from
> > your point of view, unless you get other comments sharing my thoughts.
> > 
> > Thanks anyway for the cleanup :)
> > 
> > Cheers,
> > Miqu?l
> >   
> Hum. You're right, consistency is a good thing.
> I looked around in other files, but I don't think a standard emerges.
> How about I resend the series changing all the remaining functions
> (there's only 3 remaining) to the "NULL/goto out" scheme ?
> 

Sure :)  Maybe you can wait a bit for more feedback before resending
the 18-patch series though.

Cheers,
Miqu?l