From: Jorge Ramirez-Ortiz, Foundries <jorge@foundries.io>
To: u-boot@lists.denx.de
Subject: [PATCH] mx6: peripheral clock from oscillator
Date: Thu, 22 Oct 2020 23:24:44 +0200 [thread overview]
Message-ID: <20201022212444.GA4707@trex> (raw)
In-Reply-To: <CAOMZO5CCnx6mu7j63Dn77mhOQG_MkokX8G_grMSvzzD45eB3EQ@mail.gmail.com>
On 22/10/20, Fabio Estevam wrote:
> On Mon, Oct 19, 2020 at 11:23 AM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
> >
> > In order to be able to run the I2C bus at 400Khz, the chip errata[1]
> > recommends that the peripheral clock runs out of the 24MHz oscillator.
>
> I would suggest adding the optee related motivation that you explained
> earlier here in the commit log too.
sure, will do.
>
> > [1] Rev 2, 10/2019, ERR007805
>
> Not clear what document this refers to.
um, weird, I just googled "imx Rev 2, 10/2019, ERR007805" and it showed
the document and a link to the errata.
how do you tipically do this otherwise? I didnt want to depend on
links that migh break in the future.
>
> > /* Set perclk to source from OSC 24MHz */
> > - if (is_mx6sl())
> > + if (is_mx6sl() || ERRATA_ERR007805)
>
> This gives the impression that imx6sl is not affected by the erratum,
> but in fact it is:
> https://www.nxp.com/docs/en/errata/IMX6SLCE.pdf
>
> You could define it like this:
>
> #define has_err007805() (is_mx6sl() || is_mx6dl() || is_mx6solo() ||
> is_mx6ull())
sounds good. will do (I didnt know the reason for the mx6sl configuring the
clock was that same errata)
next prev parent reply other threads:[~2020-10-22 21:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 14:23 [PATCH] mx6: peripheral clock from oscillator Jorge Ramirez-Ortiz
2020-10-22 15:18 ` Jorge
2020-10-22 20:51 ` Fabio Estevam
2020-10-22 21:24 ` Jorge [this message]
2020-10-22 21:30 ` Fabio Estevam
2020-10-23 6:35 ` Jorge
2020-10-23 12:13 ` Fabio Estevam
-- strict thread matches above, loose matches on Subject: below --
2020-10-14 13:07 Jorge Ramirez-Ortiz
2020-10-16 12:41 ` Jorge
2020-10-19 6:40 ` Peng Fan
2020-10-19 12:32 ` Fabio Estevam
2020-10-19 12:57 ` Jorge
2020-10-19 14:24 ` Jorge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022212444.GA4707@trex \
--to=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox