From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] common: rename getc() to getchar()
Date: Thu, 22 Oct 2020 20:27:36 -0400 [thread overview]
Message-ID: <20201023002736.GA14816@bill-the-cat> (raw)
In-Reply-To: <20201007161148.59389-1-xypron.glpk@gmx.de>
On Wed, Oct 07, 2020 at 06:11:48PM +0200, Heinrich Schuchardt wrote:
> The sandbox is built with the SDL2 library with invokes the X11 library
> which in turn calls getc(). But getc() in glibc is defined as
>
> int getc(FILE *)
>
> This does not match our definition.
>
> int getc(void)
>
> The sandbox crashes when called with parameter -l.
>
> Rename our library symbol getc() to getchar().
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/99e44332/attachment.sig>
prev parent reply other threads:[~2020-10-23 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 16:11 [PATCH 1/1] common: rename getc() to getchar() Heinrich Schuchardt
2020-10-07 21:25 ` Tom Rini
2020-10-07 21:26 ` Simon Glass
2020-10-23 0:27 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023002736.GA14816@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox