[patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

Kever Yang
2020-11-13T10:32:26Z

On 2020/10/31 ??2:20, Arnaud Patard (Rtp) wrote:
> Kever Yang <kever.yang@rock-chips.com> writes:
>
>> Hi Arnaud,
>>
>> ??? Thanks for your patch.
>>
>> ??? Please use module name as subject prefix instead of a file name,
>> eg. "rockchip: video: vop".
>>
> ok. will fix.
>
>> On 2020/10/27 ??9:21, Arnaud Patard (Rtp) wrote:
>>> The current code is using an hard coded enum and the of node reg value of
>>> endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order
>>> is different between rk3288, rk3399 vop little, rk3399 vop big.
>>>
>>> A possible solution would be to make sure that the rk3288.dtsi and
>>> rk3399.dtsi files have "expected" reg value or an other solution is
>>> to find the kind of endpoint by comparing the endpoint compatible value.
>>>
>>> This patch is implementing the more flexible second solution.
>>>
>>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>>>
>>> Index: u-boot/arch/arm/include/asm/arch-rockchip/vop_rk3288.h
>>> ===================================================================
>>> --- u-boot.orig/arch/arm/include/asm/arch-rockchip/vop_rk3288.h
>>> +++ u-boot/arch/arm/include/asm/arch-rockchip/vop_rk3288.h
>> For the patch format, please make sure the u-boot is the root directory.
>>
> Can you please explain this point ? It's a valid patch which can be
> applied with patch -p1. I've been generating patches with quilt for ages
> and patches got merged in various projects including in the kernel even
> before git, so I fail to get what's wrong with it.
> Or are you telling me that uboot is accepting only patches generated with git ?

Sorry, I though this patch may not able to apply with git am, but after
try with it,

this patch can be apply directly, them I think you don't need to update
this.

Thanks,

- Kever

>
> Arnaud
>
>