From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: u-boot@lists.denx.de
Subject: [patch v2 09/10] drivers/video/rockchip/rk_edp.c: Add missing reset support
Date: Tue, 27 Oct 2020 14:21:40 +0100 [thread overview]
Message-ID: <20201027132236.137690139@rtp-net.org> (raw)
In-Reply-To: 20201027132131.016984025@rtp-net.org
In order to ensure that the eDP registers are in correct state,
add missing support for the eDP reset lines found in the device-tree.
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Index: u-boot/drivers/video/rockchip/rk_edp.c
===================================================================
--- u-boot.orig/drivers/video/rockchip/rk_edp.c
+++ u-boot/drivers/video/rockchip/rk_edp.c
@@ -8,11 +8,13 @@
#include <clk.h>
#include <display.h>
#include <dm.h>
+#include <dm/device_compat.h>
#include <edid.h>
#include <log.h>
#include <malloc.h>
#include <panel.h>
#include <regmap.h>
+#include <reset.h>
#include <syscon.h>
#include <asm/gpio.h>
#include <asm/io.h>
@@ -1047,6 +1049,7 @@ static int rk_edp_probe(struct udevice *
struct rk_edp_priv *priv = dev_get_priv(dev);
struct rk3288_edp *regs = priv->regs;
struct rockchip_dp_data *edp_data = (struct rockchip_dp_data *)dev_get_driver_data(dev);
+ struct reset_ctl dp_rst;
struct clk clk;
int ret;
@@ -1059,6 +1062,25 @@ static int rk_edp_probe(struct udevice *
return ret;
}
+ ret = reset_get_by_name(dev, "dp", &dp_rst);
+ if (ret) {
+ dev_err(dev, "failed to get dp reset (ret=%d)\n", ret);
+ return ret;
+ }
+
+ ret = reset_assert(&dp_rst);
+ if (ret) {
+ dev_err(dev, "failed to assert dp reset (ret=%d)\n", ret);
+ return ret;
+ }
+ udelay(20);
+
+ ret = reset_deassert(&dp_rst);
+ if (ret) {
+ dev_err(dev, "failed to deassert dp reset (ret=%d)\n", ret);
+ return ret;
+ }
+
int vop_id = uc_plat->source_id;
debug("%s, uc_plat=%p, vop_id=%u\n", __func__, uc_plat, vop_id);
next prev parent reply other threads:[~2020-10-27 13:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:21 [patch v2 00/10] rk3399 (Pinebook pro) EDP support Arnaud Patard
2020-10-27 13:21 ` [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode Arnaud Patard
2020-10-27 22:31 ` Alper Nebi Yasak
2020-10-30 15:16 ` Kever Yang
2020-10-30 18:20 ` Arnaud Patard
2020-11-13 10:32 ` Kever Yang
2020-10-27 13:21 ` [patch v2 02/10] drivers/video/rockchip/rk_edp.c: Add rk3399 support Arnaud Patard
2020-10-27 22:32 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 03/10] drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration Arnaud Patard
2020-10-27 22:32 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 04/10] drivers/video/rockchip/rk_vop.c: Reserve efi fb memory Arnaud Patard
2020-10-27 22:33 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 05/10] rk3399-pinebook-pro-u-boot.dtsi: Enable edp Arnaud Patard
2020-10-27 14:32 ` Peter Robinson
2020-10-27 13:21 ` [patch v2 06/10] configs/pinebook-pro-rk3399_defconfig: enable SYS_USB_EVENT_POLL_VIA_INT_QUEUE Arnaud Patard
2020-10-27 13:21 ` [patch v2 07/10] drivers/pwm/rk_pwm.c: Fix default polarity Arnaud Patard
2020-10-27 22:34 ` Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 08/10] drivers/video/rockchip/rk_vop.c: Fix format of fbbase in debug string Arnaud Patard
2020-10-27 22:36 ` Alper Nebi Yasak
2020-10-27 13:21 ` Arnaud Patard [this message]
2020-10-27 22:37 ` [patch v2 09/10] drivers/video/rockchip/rk_edp.c: Add missing reset support Alper Nebi Yasak
2020-10-27 13:21 ` [patch v2 10/10] drivers/video/rockchip/rk_vop.c: Add " Arnaud Patard
2020-10-27 22:37 ` Alper Nebi Yasak
2020-10-27 22:19 ` [patch v2 00/10] rk3399 (Pinebook pro) EDP support Alper Nebi Yasak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027132236.137690139@rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox