public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 00/22] log: Add commands for manipulating filters
Date: Tue, 27 Oct 2020 19:55:19 -0400	[thread overview]
Message-ID: <20201027235541.706077-1-seanga2@gmail.com> (raw)

This series adds several commands for adding, listing, and removing log filters.
It also adds getopt, since the filter-add command needs to have several
optional arguments to be complete, and positional specification of those
arguments would have been difficult.

Passing CI:
https://dev.azure.com/seanga2/u-boot/_build/results?buildId=58&view=results

Changes in v4:
- Add a space in between the <= operator and the log level
- Add some more examples to docs
- Rebase onto master
- Remove "log: Add new category names to log_cat_name" since it has been
  superseded.
- Wrap UCLASS_ literals with log_uc_cat when used as log categories

Changes in v3:
- Convert log_test from python to C
- Document assumption that erroneous results from log_get_cat_name begin with
  '<'
- Fix heading level of Filters section
- Remove a few more already-implemented features from the TODO list
- Update copyright for log_filter.c

Changes in v2:
- Add % before constants in kerneldocs
- Add a few informational commands
- Add const qualifier to log_*_name
- Add option to remove all filters to filter-remove
- Clarify filter-* help text
- Clarify wording of filter documentation
- Converted log filter-* tests to C from python
- Document log_level_t and log_category_t members
- Expand documentation of getopt() to include examples
- Expose log_has_cat and log_has_file for filter tests
- Include enum definitions instead of re-documenting them
- Print an error message if the log level is invalid.
- Remove opt prefix from getopt_state members
- Reorganize log documentation; related sections should now be more proximate

Sean Anderson (22):
  log: Fix missing negation of ENOMEM
  log: Fix incorrect documentation of log_filter.cat_list
  log: Add additional const qualifier to arrays
  log: Use CONFIG_IS_ENABLED() for LOG_TEST
  log: Expose some helper functions
  log: Add function to create a filter with flags
  log: Add filter flag to deny on match
  test: log: Convert log_test from python to C
  test: log: Give tests names instead of numbers
  test: Add tests for LOGFF_DENY
  log: Add filter flag to match greater than a log level
  test: Add test for LOGFF_MIN
  cmd: log: Use sub-commands for log
  cmd: log: Split off log level parsing
  cmd: log: Add commands to list categories and drivers
  cmd: log: Make "log level" print all log levels
  lib: Add getopt
  test: Add a test for getopt
  cmd: log: Add commands to manipulate filters
  test: Add a test for log filter-*
  doc: Add log kerneldocs to documentation
  doc: Update logging documentation

 MAINTAINERS               |   1 +
 cmd/Kconfig               |   1 +
 cmd/log.c                 | 354 ++++++++++++++++++++++---
 common/log.c              |  58 ++---
 doc/api/getopt.rst        |   8 +
 doc/api/index.rst         |   1 +
 doc/develop/logging.rst   | 224 ++++++++--------
 include/getopt.h          | 130 +++++++++
 include/log.h             | 212 +++++++++++----
 include/test/log.h        |   3 +
 lib/Kconfig               |   5 +
 lib/Makefile              |   1 +
 lib/getopt.c              | 125 +++++++++
 test/lib/Makefile         |   1 +
 test/lib/getopt.c         | 123 +++++++++
 test/log/Makefile         |   1 +
 test/log/log_filter.c     | 108 ++++++++
 test/log/log_test.c       | 536 +++++++++++++++++++++++++-------------
 test/log/syslog_test.h    |   2 -
 test/py/tests/test_log.py | 104 --------
 20 files changed, 1470 insertions(+), 528 deletions(-)
 create mode 100644 doc/api/getopt.rst
 create mode 100644 include/getopt.h
 create mode 100644 lib/getopt.c
 create mode 100644 test/lib/getopt.c
 create mode 100644 test/log/log_filter.c

-- 
2.28.0

             reply	other threads:[~2020-10-27 23:55 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 23:55 Sean Anderson [this message]
2020-10-27 23:55 ` [PATCH v4 01/22] log: Fix missing negation of ENOMEM Sean Anderson
2020-10-30 18:46   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 02/22] log: Fix incorrect documentation of log_filter.cat_list Sean Anderson
2020-10-30 18:46   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 03/22] log: Add additional const qualifier to arrays Sean Anderson
2020-10-30 18:46   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 04/22] log: Use CONFIG_IS_ENABLED() for LOG_TEST Sean Anderson
2020-10-30 18:46   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 05/22] log: Expose some helper functions Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 06/22] log: Add function to create a filter with flags Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 07/22] log: Add filter flag to deny on match Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 08/22] test: log: Convert log_test from python to C Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 09/22] test: log: Give tests names instead of numbers Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 10/22] test: Add tests for LOGFF_DENY Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 11/22] log: Add filter flag to match greater than a log level Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 12/22] test: Add test for LOGFF_MIN Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 13/22] cmd: log: Use sub-commands for log Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 14/22] cmd: log: Split off log level parsing Sean Anderson
2020-10-30 18:47   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 15/22] cmd: log: Add commands to list categories and drivers Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 16/22] cmd: log: Make "log level" print all log levels Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 17/22] lib: Add getopt Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 18/22] test: Add a test for getopt Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 19/22] cmd: log: Add commands to manipulate filters Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 20/22] test: Add a test for log filter-* Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 21/22] doc: Add log kerneldocs to documentation Sean Anderson
2020-10-30 18:48   ` Tom Rini
2020-10-27 23:55 ` [PATCH v4 22/22] doc: Update logging documentation Sean Anderson
2020-10-30 18:48   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027235541.706077-1-seanga2@gmail.com \
    --to=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox