From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [RESEND PATCH v6 00/17] efi_loader: add capsule update support
Date: Wed, 28 Oct 2020 23:22:29 -0400 [thread overview]
Message-ID: <20201029032229.GW5340@bill-the-cat> (raw)
In-Reply-To: <20201029005912.GA34763@laputa>
On Thu, Oct 29, 2020 at 09:59:12AM +0900, AKASHI Takahiro wrote:
> Tom,
>
> On Wed, Oct 28, 2020 at 08:30:49PM -0400, Tom Rini wrote:
> > On Thu, Oct 29, 2020 at 09:25:11AM +0900, AKASHI Takahiro wrote:
> >
> > > #
> > > # This is a reminder. Nothing changed, but rebasing.
> > > #
> >
> > Wasn't one of the outstanding requests to make the DFU related changes
> > less intrusive and thus easier to review
>
> I don't know what you're talking about.
> I believe that I have addressed all the comments made on DFU stuff.
Please go back and re-read the v5 thread then. What you're doing today
causes odroid, trats, trats2 and s5p_goni to fail to build now and I
believe there was a suggestion what to do to fix that, previously.
>
> There used to be a prerequisite patch from Heinrich, but he decided
> to drop it. Necessary modification was done in v5.
>
> > by someone (me) who is not the
> > primary author of the DFU code but does want to unblock this overall
> > series right here?
>
> So you can review DFU part now (or even against the original v6).
> # Another minor issue: the name of file, dfu_alt.c
> # It will never be a blocking factor of your review, though.
>
> The only outstanding issue is on make-virt-fs[1].
> Here, my standpoint is clear: Heinrich's patch.
> It is the only solution as far as Heinrich does reject any other solution
> using 'sudo' in python scripts.
Which is I guess why the tests fail to run here:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/171480
and why I think I had suggested that you need to do some try/catch logic
so that if one set of tools isn't available, the other set of tools will
be used.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201028/362fe8ef/attachment.sig>
next prev parent reply other threads:[~2020-10-29 3:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 0:25 [RESEND PATCH v6 00/17] efi_loader: add capsule update support AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 01/17] dfu: rename dfu_tftp_write() to dfu_write_by_name() AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 02/17] dfu: modify an argument type for an address AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 03/17] common: update: add a generic interface for FIT image AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 04/17] dfu: export dfu_list AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 05/17] efi_loader: add option to initialise EFI subsystem early AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 06/17] efi_loader: add efi_create_indexed_name() AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 07/17] efi_loader: define UpdateCapsule api AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 08/17] efi_loader: capsule: add capsule_on_disk support AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 09/17] efi_loader: capsule: add memory range capsule definitions AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 10/17] efi_loader: capsule: support firmware update AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 11/17] efi_loader: add firmware management protocol for FIT image AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 12/17] dfu: add dfu_write_by_alt() AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 13/17] efi_loader: add firmware management protocol for raw image AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 14/17] cmd: add "efidebug capsule" command AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 15/17] tools: add mkeficapsule command for UEFI capsule update AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 16/17] test/py: efi_capsule: test for FIT image capsule AKASHI Takahiro
2020-10-29 0:25 ` [RESEND PATCH v6 17/17] test/py: efi_capsule: test for raw " AKASHI Takahiro
2020-10-29 0:30 ` [RESEND PATCH v6 00/17] efi_loader: add capsule update support Tom Rini
2020-10-29 0:59 ` AKASHI Takahiro
2020-10-29 3:22 ` Tom Rini [this message]
2020-10-29 3:57 ` AKASHI Takahiro
2020-10-29 4:40 ` AKASHI Takahiro
2020-10-29 14:38 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029032229.GW5340@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox