From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
Date: Thu, 29 Oct 2020 12:14:56 -0400 [thread overview]
Message-ID: <20201029161456.GN5340@bill-the-cat> (raw)
In-Reply-To: <716e58eb-c5cd-6a6b-1d93-cd72592cb5c4@collabora.com>
On Thu, Oct 29, 2020 at 01:11:15PM -0300, Walter Lozano wrote:
>
> On 29/10/20 12:19, Tom Rini wrote:
> > On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote:
> > > Hi Simon,
> > >
> > > Adding Walter to Cc.
> > >
> > > On Thu, Oct 29 2020, Simon Glass wrote:
> > > > This feature is incompatble with of-platdata since it uses the
> > > > U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are
> > > > those created by dtoc.
> > > >
> > > > Drop this option for now, until the driver can be corrected.
> > > As I understand, of-platdata is only enabled in SPL. Is there a way to
> > > limit imx_thermal drop to SPL? The thermal driver in not very useful in
> > > SPL anyway, right?
>
> As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of
> DTB and libraries. If this option is enabled and the driver does not support
> it, the device won't be created in TPL/SPL but is should on U-Boot. In order
> to limit the drop to SPL can CONFIG_SPL_BUILD be used?
>
> Regarding the usefulness of im_thermal in SPL I can't comment.
>
> > Well, sigh, step one is to finish the migration to Kconfig for
> > IMX_THERMAL as it has a symbol, but it's still set in a ton of board
> > config files. We only build thermal in SPL when SPL_THERMAL is set, so
> > I assume this is about trying to use of-platdata in U-Boot proper too,
> > to keep / further reduce the size of U-Boot itself to stay within size
> > limits.
Well, I suspect maybe part of the problem is that since the symbol
isn't migrated properly, it's not being not built when we don't need it.
I did the migration and queued up a build, I should have some answers
later today.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201029/b7f17b01/attachment.sig>
next prev parent reply other threads:[~2020-10-29 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 0:02 [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL Simon Glass
2020-10-29 5:14 ` Baruch Siach
2020-10-29 15:19 ` Tom Rini
2020-10-29 16:11 ` Walter Lozano
2020-10-29 16:14 ` Tom Rini [this message]
2020-10-29 17:06 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029161456.GN5340@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox