From: Qu Wenruo <wqu@suse.com>
To: u-boot@lists.denx.de
Subject: [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy
Date: Sat, 31 Oct 2020 09:07:52 +0800 [thread overview]
Message-ID: <20201031010752.23974-5-wqu@suse.com> (raw)
In-Reply-To: <20201031010752.23974-1-wqu@suse.com>
In show_dir() if we hit file type FT_CHRDEV or FT_BLKDEV, we expect an
BTRFS_INODE_ITEM_KEY, and for that case, we should have @ii filled with
data read from disk.
We even have ASSERT() for this purpose, but unfortunately coverity can't
understand the ASSERT() nor if we get key type BTRFS_INODE_ITEM_KEY,
previous if() branch must go to the read_extent_buffer() branch to fill
the @ii.
So to make coverity happy, just initialize the variable @ii to all zero.
Reported-by: Coverity CID 312950
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/btrfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/btrfs.c b/fs/btrfs/btrfs.c
index 346b2c4341c2..1abd2c291177 100644
--- a/fs/btrfs/btrfs.c
+++ b/fs/btrfs/btrfs.c
@@ -19,7 +19,7 @@ static int show_dir(struct btrfs_root *root, struct extent_buffer *eb,
struct btrfs_dir_item *di)
{
struct btrfs_fs_info *fs_info = root->fs_info;
- struct btrfs_inode_item ii;
+ struct btrfs_inode_item ii = { 0 };
struct btrfs_key key;
static const char* dir_item_str[] = {
[BTRFS_FT_REG_FILE] = "FILE",
--
2.29.1
next prev parent reply other threads:[~2020-10-31 1:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 1:07 [PATCH 0/4] fs: btrfs: coverity fixes Qu Wenruo
2020-10-31 1:07 ` [PATCH 1/4] fs: btrfs: inode: handle uninitialized type before returning it Qu Wenruo
2020-11-01 22:59 ` Marek Behun
2020-11-20 1:36 ` Tom Rini
2020-10-31 1:07 ` [PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying Qu Wenruo
2020-11-01 23:02 ` Marek Behun
2020-11-02 0:20 ` Qu Wenruo
2020-11-02 1:06 ` Qu Wenruo
2021-01-20 21:46 ` Tom Rini
2020-10-31 1:07 ` [PATCH 3/4] fs: btrfs: initialize @ret to 0 to prevent uninitialized return value Qu Wenruo
2020-11-01 23:03 ` Marek Behun
2020-11-20 1:36 ` Tom Rini
2020-10-31 1:07 ` Qu Wenruo [this message]
2020-11-01 23:06 ` [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy Marek Behun
2020-11-02 0:27 ` Qu Wenruo
2020-11-02 7:24 ` Marek Behun
2020-11-02 7:27 ` Qu Wenruo
2020-11-02 20:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031010752.23974-5-wqu@suse.com \
--to=wqu@suse.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox