From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 2 Nov 2020 15:17:16 -0500 Subject: [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy In-Reply-To: <20201102082409.7b5cce51@nic.cz> References: <20201031010752.23974-1-wqu@suse.com> <20201031010752.23974-5-wqu@suse.com> <20201102000656.241101c5@nic.cz> <2e5530d6-e5e9-8c4b-686c-5c39b8339c86@suse.com> <20201102082409.7b5cce51@nic.cz> Message-ID: <20201102201716.GO5340@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Nov 02, 2020 at 08:24:09AM +0100, Marek Behun wrote: > On Mon, 2 Nov 2020 08:27:16 +0800 > Qu Wenruo wrote: > > > Thus I really tend to believe it's just a bug in coverity. > > All locations accessing @ii all have its key.type checked to ensure it get filled in the first place. > > If this is a bug in coverity, we should fix coverity, not add extra > code to U-Boot, even if it is just one instruction. That simply stinks > the same way like when systemd crashed when "debug" parameter was > present in /proc/cmdline, and they sent a patch to kernel which removed > the "debug" parameter, instead of fixing systemd. IMO. To be clear, I am quite happy to mark as intentional any issues that are flagged by Coverity but, well, intentional and not a problem. We may also benefit from adding a "modeling" file to help Coverity know when some cases of issues are handled by us already. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: