public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hoyeonjiki Kim <jigi.kim@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] env: mmc: Correct partition comparison in mmc_offset_try_partition
Date: Thu, 12 Nov 2020 22:12:37 +0900	[thread overview]
Message-ID: <20201112131237.1239-1-jigi.kim@gmail.com> (raw)

The function mmc_offset_try_partition searches MMC partition to save the
environment data by name.  However, it only compares the first word-size
bytes (size of 'const char *'), which may make the function to find
unintended partition.

Correct the function not to partially compare the partition name with
config "u-boot,mmc-env-partition".

Fixes: c9e87ba66540 ("env: Save environment at the end of an MMC partition")
Signed-off-by: Hoyeonjiki Kim <jigi.kim@gmail.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 env/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/env/mmc.c b/env/mmc.c
index 4e67180b23..505f7aa2b8 100644
--- a/env/mmc.c
+++ b/env/mmc.c
@@ -42,7 +42,7 @@ static inline int mmc_offset_try_partition(const char *str, int copy, s64 *val)
 		if (ret < 0)
 			return ret;
 
-		if (!strncmp((const char *)info.name, str, sizeof(str)))
+		if (!strcmp((const char *)info.name, str))
 			break;
 	}
 
-- 
2.25.1

             reply	other threads:[~2020-11-12 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 13:12 Hoyeonjiki Kim [this message]
2020-11-12 20:07 ` [PATCH v2] env: mmc: Correct partition comparison in mmc_offset_try_partition Wolfgang Denk
2020-11-13  4:03   ` Hoyeonjiki Kim
2020-11-15 16:36     ` Wolfgang Denk
2020-11-15 17:01       ` Hoyeonjiki Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112131237.1239-1-jigi.kim@gmail.com \
    --to=jigi.kim@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox