From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: Pull request: u-boot-sunxi/master
Date: Mon, 16 Nov 2020 11:58:29 -0500 [thread overview]
Message-ID: <20201116165829.GT5340@bill-the-cat> (raw)
In-Reply-To: <fc75043d-b497-cad6-7aab-2e9cc01437b3@arm.com>
On Mon, Nov 16, 2020 at 04:51:32PM +0000, Andr? Przywara wrote:
> On 16/11/2020 16:13, Tom Rini wrote:
> > On Mon, Nov 16, 2020 at 04:09:42PM +0000, Andr? Przywara wrote:
> >> On 16/11/2020 15:50, Tom Rini wrote:
> >>
> >> Hi Tom,
> >>
> >>> On Mon, Nov 16, 2020 at 12:42:53PM +0530, Jagan Teki wrote:
> >>>
> >>>> Hi Tom,
> >>>>
> >>>> Please pull this PR.
> >>>>
> >>>> Summary:
> >>>> - PinePhone support (Samuel)
> >>>> - V3/S3 support (Icenowy)
> >>>>
> >>>> thanks,
> >>>> Jagan.
> >>>>
> >>>> The following changes since commit de865f7ee1d9b6dff6e265dee44509c8274ea606:
> >>>>
> >>>> Merge tag 'efi-2021-01-rc3' of https://gitlab.denx.de/u-boot/custodians/u-boot-efi (2020-11-14 09:47:33 -0500)
> >>>>
> >>>> are available in the Git repository at:
> >>>>
> >>>> https://gitlab.denx.de/u-boot/custodians/u-boot-sunxi master
> >>>>
> >>>> for you to fetch changes up to 27007e5d4a6c4ac1bbd1bc81fb4c19bc45191f35:
> >>>>
> >>>> sunxi: dts: sync Allwinner V3s-related DTs from Linux 5.10-rc1 (2020-11-16 12:34:09 +0530)
> >>>>
> >>>
> >>> NAK. A large number of sunxi boards fail to build with:
> >>> +board/sunxi/board.c:338:13: error: 'set_spl_dt_name' defined but not used [-Werror=unused-function]
> >>> + 338 | static void set_spl_dt_name(const char *name)
> >>> + | ^~~~~~~~~~~~~~~
> >>> +cc1: all warnings being treated as errors
> >>> +make[2]: *** [board/sunxi/board.o] Error 1
> >>> +make[1]: *** [board/sunxi] Error 2
> >>> +make: *** [sub-make] Error 2
> >>
> >> Ouch, thanks for that heads up!
> >> But this only happens after this very patch, and is fixed by a later
> >> patch, right? ("sunxi: board: Set fdtfile to match the DT chosen by SPL"
> >> introduces another user of set_spl_dt_name(), outside of any #ifdef's).
> >
> > No, that's from the PR itself.
>
> Right, sorry, looked at the wrong function.
> I found the culprit and have a fix, but I will run some actual tests on
> my boards tonight to make sure it really works.
> Jagan or me will send a new PR later then.
OK, thanks for the quick follow-up!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201116/3463ef2a/attachment.sig>
next prev parent reply other threads:[~2020-11-16 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 7:12 Pull request: u-boot-sunxi/master Jagan Teki
2020-11-16 15:50 ` Tom Rini
2020-11-16 16:09 ` André Przywara
2020-11-16 16:13 ` Tom Rini
2020-11-16 16:51 ` André Przywara
2020-11-16 16:58 ` Tom Rini [this message]
2020-11-17 1:56 ` Samuel Holland
2020-11-17 8:50 ` André Przywara
-- strict thread matches above, loose matches on Subject: below --
2020-10-22 19:33 Jagan Teki
2020-10-23 13:18 ` Tom Rini
2020-06-02 18:49 Jagan Teki
2020-06-03 16:27 ` Tom Rini
2020-03-30 7:14 Jagan Teki
2020-03-30 23:30 ` Tom Rini
2020-03-18 10:12 Jagan Teki
2020-03-18 13:56 ` Tom Rini
2020-01-26 16:38 Jagan Teki
2020-01-26 19:13 ` Tom Rini
2019-12-27 12:26 Jagan Teki
2019-12-28 4:30 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116165829.GT5340@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox