From: Leo Liang <ycliang@andestech.com>
To: u-boot@lists.denx.de
Subject: [PATCH] riscv: fix the wrong swap value register
Date: Thu, 19 Nov 2020 18:27:05 +0800 [thread overview]
Message-ID: <20201119102659.GA5712@andestech.com> (raw)
In-Reply-To: <20201113114751.19340-1-brad.kim@semifive.com>
On Fri, Nov 13, 2020 at 08:47:51PM +0900, Brad Kim wrote:
> Not s2 register, t1 register is correct
> Fortunately, it works because t1 register has a garbage value
>
> Signed-off-by: Brad Kim <brad.kim@semifive.com>
> Reviewed-by: Lukas Auer <lukas@auer.io>
> ---
> arch/riscv/cpu/start.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S
> index bbc737ed9a..8589509e01 100644
> --- a/arch/riscv/cpu/start.S
> +++ b/arch/riscv/cpu/start.S
> @@ -123,7 +123,7 @@ call_board_init_f_0:
> * wait for initialization to complete.
> */
> la t0, hart_lottery
> - li s2, 1
> + li t1, 1
> amoswap.w s2, t1, 0(t0)
> bnez s2, wait_for_gd_init
> #else
Reviewed-by: Leo Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2020-11-19 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:47 [PATCH] riscv: fix the wrong swap value register Brad Kim
2020-11-13 12:18 ` Lukas Auer
2020-11-19 10:27 ` Leo Liang [this message]
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FB2304CBC@ATCPCS16.andestech.com>
2020-11-23 9:19 ` Rick Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119102659.GA5712@andestech.com \
--to=ycliang@andestech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox