public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v9 11/11] sandbox: enable capsule update for testing
Date: Wed, 25 Nov 2020 09:46:16 +0900	[thread overview]
Message-ID: <20201125004616.GA8300@laputa> (raw)
In-Reply-To: <3dedc03d-bfbf-4bc0-24b1-1882a86b6930@gmx.de>

Heinrich,

On Tue, Nov 24, 2020 at 08:05:45PM +0100, Heinrich Schuchardt wrote:
> On 11/17/20 1:28 AM, AKASHI Takahiro wrote:
> > Add more configuration options to allow for efi capsule update
> > on sandbox.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> 
> This patch leads to a build failure:
> 
> https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/jobs/181984
> 
> Building current source for 1 boards (1 thread, 40 jobs per thread)
>    sandbox:  +   sandbox
> +common/update.c:178:12: error: 'update_flash' defined but not used
> [-Werror=unused-function]
> + static int update_flash(ulong addr_source, ulong addr_first, ulong size)
> +            ^~~~~~~~~~~~
> +cc1: all warnings being treated as errors
> +make[2]: *** [common/update.o] Error 1
> +make[1]: *** [common] Error 2
> +make: *** [sub-make] Error 2
> 
> I suggest you mark function update_fetch as __maybe_unused.

I suppose that you have not applied my patch:
https://lists.denx.de/pipermail/u-boot/2020-November/433064.html

-Takahiro Akashi


> Best regards
> 
> Heinrich
> 
> 
> > ---
> >   configs/sandbox64_defconfig | 6 ++++++
> >   configs/sandbox_defconfig   | 6 ++++++
> >   2 files changed, 12 insertions(+)
> > 
> > diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
> > index dc993cd13aaa..661830763feb 100644
> > --- a/configs/sandbox64_defconfig
> > +++ b/configs/sandbox64_defconfig
> > @@ -231,3 +231,9 @@ CONFIG_TEST_FDTDEC=y
> >   CONFIG_UNIT_TEST=y
> >   CONFIG_UT_TIME=y
> >   CONFIG_UT_DM=y
> > +#
> > +CONFIG_DFU_SF=y
> > +CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
> > +CONFIG_EFI_CAPSULE_ON_DISK=y
> > +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
> > +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y
> > diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> > index f2a767a4cdea..e385425b7d91 100644
> > --- a/configs/sandbox_defconfig
> > +++ b/configs/sandbox_defconfig
> > @@ -274,3 +274,9 @@ CONFIG_TEST_FDTDEC=y
> >   CONFIG_UNIT_TEST=y
> >   CONFIG_UT_TIME=y
> >   CONFIG_UT_DM=y
> > +#
> > +CONFIG_DFU_SF=y
> > +CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y
> > +CONFIG_EFI_CAPSULE_ON_DISK=y
> > +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y
> > +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y
> > 
> 

  reply	other threads:[~2020-11-25  0:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17  0:27 [PATCH v9 00/11] efi_loader: add capsule update support AKASHI Takahiro
2020-11-17  0:27 ` [PATCH v9 01/11] efi_loader: define UpdateCapsule api AKASHI Takahiro
2020-11-17  0:27 ` [PATCH v9 02/11] efi_loader: capsule: add capsule_on_disk support AKASHI Takahiro
2020-11-17  0:27 ` [PATCH v9 03/11] efi_loader: capsule: add memory range capsule definitions AKASHI Takahiro
2020-11-17  0:27 ` [PATCH v9 04/11] efi_loader: capsule: support firmware update AKASHI Takahiro
2020-11-21 18:02   ` Sughosh Ganu
2020-11-24  5:51     ` AKASHI Takahiro
2020-11-24  7:37       ` Sughosh Ganu
2020-11-24  8:31         ` AKASHI Takahiro
2020-11-25  1:00   ` Heinrich Schuchardt
2020-11-25  2:12     ` AKASHI Takahiro
2020-11-17  0:27 ` [PATCH v9 05/11] efi_loader: add firmware management protocol for FIT image AKASHI Takahiro
2020-11-17  0:28 ` [PATCH v9 06/11] efi_loader: add firmware management protocol for raw image AKASHI Takahiro
2020-11-17  0:28 ` [PATCH v9 07/11] cmd: add "efidebug capsule" command AKASHI Takahiro
2020-11-17  0:28 ` [PATCH v9 08/11] tools: add mkeficapsule command for UEFI capsule update AKASHI Takahiro
2020-11-24 20:23   ` Heinrich Schuchardt
2020-11-25  1:05     ` AKASHI Takahiro
2020-11-25  1:36       ` AKASHI Takahiro
2020-11-25  6:42       ` Heinrich Schuchardt
2020-11-25  7:32         ` AKASHI Takahiro
2020-11-27 14:22           ` Heinrich Schuchardt
2020-11-29  4:59             ` Heinrich Schuchardt
2020-11-29 23:45               ` AKASHI Takahiro
2020-11-25  5:17     ` AKASHI Takahiro
2020-11-25  6:31       ` Sughosh Ganu
2020-11-25  7:28         ` AKASHI Takahiro
2020-11-17  0:28 ` [PATCH v9 09/11] test/py: efi_capsule: test for FIT image capsule AKASHI Takahiro
2020-11-17  0:28 ` [PATCH v9 10/11] test/py: efi_capsule: test for raw " AKASHI Takahiro
2020-11-17  0:28 ` [PATCH v9 11/11] sandbox: enable capsule update for testing AKASHI Takahiro
2020-11-24 19:05   ` Heinrich Schuchardt
2020-11-25  0:46     ` AKASHI Takahiro [this message]
2020-11-24 21:37 ` [PATCH v9 00/11] efi_loader: add capsule update support Heinrich Schuchardt
2020-11-24 23:32   ` Tom Rini
2020-11-25  2:07     ` Heinrich Schuchardt
2020-11-25  2:23       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125004616.GA8300@laputa \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox