From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default
Date: Sun, 29 Nov 2020 17:52:52 +0100 [thread overview]
Message-ID: <20201129165252.6350-1-pali@kernel.org> (raw)
In-Reply-To: <20201129164618.5829-1-pali@kernel.org>
Now when usbtty serial console is fixed in U-Boot enable it for Nokia RX-51
board by default.
CONFIG_CONSOLE_MUX is already used and U-Boot console is available for
all in/out devices. Therefore there is no need to have separate commands
'run sercon', 'run usbcon' and 'run vgacon', so remove them.
As space for U-Boot is limited to 256kB, disable some other unused options
so CONFIG_USB_TTY can be enabled.
Nokia RX-51 does not have easily accessible UART serial console so the only
option for easy debugging is to use device's keyboard+screen or this usbtty
serial console over USB.
Signed-off-by: Pali Roh?r <pali@kernel.org>
---
configs/nokia_rx51_defconfig | 6 +++---
doc/README.nokia_rx51 | 15 +--------------
include/configs/nokia_rx51.h | 16 ++++------------
3 files changed, 8 insertions(+), 29 deletions(-)
diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig
index 0f05fe6fc3..e1b874a870 100644
--- a/configs/nokia_rx51_defconfig
+++ b/configs/nokia_rx51_defconfig
@@ -44,18 +44,16 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=onenand:128k(bootloader)ro,384k(config),256k(l
CONFIG_ENV_OVERWRITE=y
CONFIG_SYS_RELOC_GD_ENV_ADDR=y
# CONFIG_NET is not set
-CONFIG_TWL4030_LED=y
# CONFIG_MMC_HW_PARTITIONING is not set
+# CONFIG_MMC_VERBOSE is not set
CONFIG_MMC_OMAP_HS=y
CONFIG_MTD=y
CONFIG_CONS_INDEX=3
CONFIG_SYS_NS16550=y
CONFIG_SPI=y
CONFIG_USB=y
-CONFIG_USB_MUSB_HCD=y
CONFIG_USB_MUSB_UDC=y
CONFIG_USB_OMAP3=y
-CONFIG_TWL4030_USB=y
CONFIG_CFB_CONSOLE=y
CONFIG_CFB_CONSOLE_ANSI=y
# CONFIG_VGA_AS_SINGLE_DEVICE is not set
@@ -66,3 +64,5 @@ CONFIG_DM_I2C=y
CONFIG_DM_MMC=y
# CONFIG_DM_DEVICE_REMOVE is not set
# CONFIG_SYS_MALLOC_F is not set
+# CONFIG_DM_WARN is not set
+# CONFIG_BLOCK_CACHE is not set
diff --git a/doc/README.nokia_rx51 b/doc/README.nokia_rx51
index 320b5efc7d..84d1912ddd 100644
--- a/doc/README.nokia_rx51
+++ b/doc/README.nokia_rx51
@@ -24,8 +24,7 @@ called u-boot-gen-combined. It is available in following repository:
There is support for hardware watchdog. Hardware watchdog is started by
NOLO so u-boot must kick watchdog to prevent reboot device (but not very
often, max every 2 seconds). There is also support for framebuffer display
-output with ANSI escape codes and the N900 HW keyboard input. USB tty works
-but is disabled because it prevents the current Maemo kernel from booting.
+output with ANSI escape codes and the N900 HW keyboard input.
When U-Boot is starting it enable IBE bit in Auxiliary Control Register,
which is needed for Thumb-2 ISA support. It is workaround for errata 430973.
@@ -49,10 +48,6 @@ Boot from SD or eMMC in this order:
Available additional commands/variables:
- * run sercon - Use serial port for control
- * run usbcon - Use usbtty for control
- * run vgacon - Use framebuffer and HW keyboard for control (default)
-
* run sdboot - Boot from external SD card (see boot order)
* run emmcboot - Boot from internal eMMC memory (see boot order)
* run attachboot - Boot attached kernel image (attached to U-Boot binary)
@@ -87,14 +82,6 @@ Additional variables for booting kernel:
and u-boot standard output is set to serial then setup_console_atag is
automatically set to 1. So output from Maemo kernel would go to serial port.
-USB TTY:
-
- Maemo kernel 2.6.28 will crash if u-boot enable usb tty. So USB TTY is disabled.
- For enabling USB TTY just add this line to file include/configs/nokia_rx51.h
-
- #define CONFIG_USB_TTY
-
-
UBIFS support:
UBIFS support is disabled, because U-Boot image is too big and cannot be
diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
index 6879f52a0c..36b1f9221c 100644
--- a/include/configs/nokia_rx51.h
+++ b/include/configs/nokia_rx51.h
@@ -70,6 +70,7 @@
/* USB device configuration */
#define CONFIG_USB_DEVICE
+#define CONFIG_USB_TTY
#define CONFIG_USBD_VENDORID 0x0421
#define CONFIG_USBD_PRODUCTID 0x01c8
#define CONFIG_USBD_MANUFACTURER "Nokia"
@@ -108,15 +109,9 @@ int rx51_kp_getc(struct stdio_dev *sdev);
/* Environment information */
#define CONFIG_EXTRA_ENV_SETTINGS \
"usbtty=cdc_acm\0" \
- "stdin=serial,vga\0" \
- "stdout=serial,vga\0" \
- "stderr=serial,vga\0" \
- "setcon=setenv stdin ${con};" \
- "setenv stdout ${con};" \
- "setenv stderr ${con}\0" \
- "sercon=setenv con serial; run setcon\0" \
- "usbcon=setenv con usbtty; run setcon\0" \
- "vgacon=setenv con vga; run setcon\0" \
+ "stdin=usbtty,serial,vga\0" \
+ "stdout=usbtty,serial,vga\0" \
+ "stderr=usbtty,serial,vga\0" \
"slide=gpio input " __stringify(GPIO_SLIDE) "\0" \
"switchmmc=mmc dev ${mmcnum}\0" \
"kernaddr=0x82008000\0" \
@@ -209,9 +204,6 @@ int rx51_kp_getc(struct stdio_dev *sdev);
#define CONFIG_POSTBOOTMENU \
"echo;" \
"echo Extra commands:;" \
- "echo run sercon - Use serial port for control.;" \
- "echo run usbcon - Use usbtty for control.;" \
- "echo run vgacon - Use framebuffer/keyboard.;" \
"echo run sdboot - Boot from SD card slot.;" \
"echo run emmcboot - Boot internal eMMC memory.;" \
"echo run attachboot - Boot attached kernel image.;" \
--
2.20.1
next prev parent reply other threads:[~2020-11-29 16:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 16:46 [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-11-29 16:46 ` [PATCH 01/13] serial: usbtty: Fix puts function Pali Rohár
2020-11-29 17:50 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 02/13] usb: musb: Fix compilation of gadget code Pali Rohár
2020-11-29 17:52 ` Pavel Machek
2021-01-16 0:18 ` Pali Rohár
2020-11-29 16:46 ` [PATCH 03/13] usb: musb: Always clear the data toggle bit when configuring ep Pali Rohár
2020-11-29 17:52 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 04/13] usb: musb: Fix configuring FIFO for endpoints Pali Rohár
2020-11-29 17:53 ` Pavel Machek
2020-12-26 18:08 ` [PATCH v2] " Pali Rohár
2020-11-29 16:46 ` [PATCH 05/13] usb: musb: Read value of PERI_RXCSR to 16bit variable Pali Rohár
2020-11-29 17:53 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 06/13] usb: musb: Fix transmission of bigger buffers Pali Rohár
2020-11-29 17:55 ` Pavel Machek
2020-11-29 16:46 ` [PATCH 07/13] usb: gadget: Do not export usbd_device_* arrays Pali Rohár
2020-11-29 17:57 ` Pavel Machek
2020-12-26 18:12 ` [PATCH v2] " Pali Rohár
2020-11-29 16:49 ` [PATCH 08/13] usb: gadget: Use dbg_ep0() macro instead of serial_printf() Pali Rohár
2020-11-29 17:57 ` Pavel Machek
2020-11-29 16:51 ` [PATCH 09/13] arm: omap3: Compile lowlevel_init() function only when it is used Pali Rohár
2020-11-29 17:59 ` Pavel Machek
2020-11-29 16:52 ` [PATCH 10/13] arm: omap3: Compile s_init() " Pali Rohár
2020-11-29 18:00 ` Pavel Machek
2020-11-29 16:52 ` [PATCH 11/13] Nokia RX-51: Remove function set_muxconf_regs() Pali Rohár
2020-11-29 16:52 ` [PATCH 12/13] Nokia RX-51: Move content of rx51.h to rx51.c Pali Rohár
2020-11-29 16:52 ` Pali Rohár [this message]
2020-11-29 18:11 ` [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default Pavel Machek
2020-11-30 19:27 ` [PATCH v2] " Pali Rohár
2020-12-22 14:26 ` Lokesh Vutla
2020-12-22 14:58 ` Pali Rohár
2020-12-22 15:06 ` Lokesh Vutla
2020-12-22 15:08 ` Lokesh Vutla
2020-12-22 15:09 ` Lokesh Vutla
2020-12-22 15:17 ` Pali Rohár
2020-12-22 15:38 ` Lokesh Vutla
2020-12-22 16:02 ` Pali Rohár
2020-12-23 6:05 ` Lokesh Vutla
2020-12-26 17:01 ` Pali Rohár
2020-12-27 16:28 ` [PATCH 13/13] " Andy Shevchenko
2020-12-27 16:35 ` Pali Rohár
2020-12-27 16:42 ` Andy Shevchenko
2020-12-27 16:50 ` Pali Rohár
2020-12-10 20:01 ` [PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2020-12-11 10:53 ` Lokesh Vutla
2020-12-19 23:46 ` Pali Rohár
2020-12-27 16:32 ` Pali Rohár
2021-01-17 10:37 ` Lokesh Vutla
2021-02-01 15:30 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129165252.6350-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox