[PATCH 00/13] Nokia RX-51: Fix USB TTY console and enable it

Pali Rohár
2020-12-10T20:01:45Z

Hello Lokesh, could you please process this patch series? USB serial
console on Nokia N900 is really useful for debugging and currently in
U-Boot master code is broken. Pavel has already reviewed patches and
also CI tests passed.

On Sunday 29 November 2020 17:46:05 Pali Roh?r wrote:
> This patch series fix usbtty code (serial console via USB peripheral
> mode), fix underlying musb peripheral code, fix compilation of
> CONFIG_USB_DEVICE (used by usbtty), remove unused Nokia RX-51 code to
> decrease size of U-Boot binary and finally enable usbtty serial console
> for Nokia RX-51.
>
> With this patch series debugging of Nokia RX-51 can be done also via USB
> serial console.
>
> On computer this serial console is accessible via /dev/ttyACM0 device.
>
> With current implementation there is an issue in musb driver that it
> loose receiving bytes from USB bus when too many a characters are send
> over USB tty from computer. Typing on keyboard to kermit terminal
> connected to /dev/ttyACM0 is working fine. But pasting more more bytes
> to terminal cause data lost on receiving side. I do not know where is
> the issue or how to fix it (it looks like that data are lost at low
> level when reading them from msub FIFO hardware) but typing on keyboard
> is working fine. This is rather issue for sending files via x/y/z-modem
> or kermit protocol. Currently U-Boot is not able to receive any file
> via usbtty with musb driver due to this issue.
>
> Pali Roh?r (13):
> serial: usbtty: Fix puts function
> usb: musb: Fix compilation of gadget code
> usb: musb: Always clear the data toggle bit when configuring ep
> usb: musb: Fix configuring FIFO for endpoints
> usb: musb: Read value of PERI_RXCSR to 16bit variable
> usb: musb: Fix transmission of bigger buffers
> usb: gadget: Do not export usbd_device_* arrays
> usb: gadget: Use dbg_ep0() macro instead of serial_printf()
> arm: omap3: Compile lowlevel_init() function only when it is used
> arm: omap3: Compile s_init() function only when it is used
> Nokia RX-51: Remove function set_muxconf_regs()
> Nokia RX-51: Move content of rx51.h to rx51.c
> Nokia RX-51: Enable usbtty serial console by default
>
> Makefile | 1 +
> arch/arm/mach-omap2/omap3/board.c | 3 +
> arch/arm/mach-omap2/omap3/lowlevel_init.S | 6 +-
> board/nokia/rx51/rx51.c | 28 +-
> board/nokia/rx51/rx51.h | 377 ----------------------
> configs/nokia_rx51_defconfig | 6 +-
> doc/README.nokia_rx51 | 15 +-
> drivers/serial/usbtty.c | 4 +-
> drivers/usb/gadget/core.c | 38 +--
> drivers/usb/gadget/ep0.c | 47 ++-
> drivers/usb/musb/musb_core.c | 10 +-
> drivers/usb/musb/musb_udc.c | 19 +-
> include/configs/nokia_rx51.h | 16 +-
> include/usbdevice.h | 15 -
> 14 files changed, 92 insertions(+), 493 deletions(-)
> delete mode 100644 board/nokia/rx51/rx51.h
>
> --
> 2.20.1
>