[PATCH] Nokia RX-51: Do not try calling both ext2load and ext4load

[PATCH] Nokia RX-51: Do not try calling both ext2load and ext4load

[Pali Rohár]

Those two commands now doing same thing, reading from ext2/3/4 filesystem.
So remove useless duplicated call.

Signed-off-by: Pali Roh?r <pali@kernel.org>
---
 include/configs/nokia_rx51.h | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
index 6879f52a0c..3f2700d8e2 100644
--- a/include/configs/nokia_rx51.h
+++ b/include/configs/nokia_rx51.h
@@ -169,8 +169,6 @@ int rx51_kp_getc(struct stdio_dev *sdev);
 	"trymmcboot=if run switchmmc; then " \
 			"setenv mmctype fat;" \
 			"run trymmcallpartboot;" \
-			"setenv mmctype ext2;" \
-			"run trymmcallpartboot;" \
 			"setenv mmctype ext4;" \
 			"run trymmcallpartboot;" \
 		"fi\0" \
@@ -179,19 +177,10 @@ int rx51_kp_getc(struct stdio_dev *sdev);
 	"preboot=setenv mmcnum 1; setenv mmcpart 1;" \
 		"setenv mmcscriptfile bootmenu.scr;" \
 		"if run switchmmc; then " \
-			"setenv mmcdone true;" \
 			"setenv mmctype fat;" \
-			"if run scriptload; then true; else " \
-				"setenv mmctype ext2;" \
-				"if run scriptload; then true; else " \
-					"setenv mmctype ext4;" \
-					"if run scriptload; then true; else " \
-						"setenv mmcdone false;" \
-					"fi;" \
-				"fi;" \
-			"fi;" \
-			"if ${mmcdone}; then " \
-				"run scriptboot;" \
+			"if run scriptload; then run scriptboot; else " \
+				"setenv mmctype ext4;" \
+				"if run scriptload; then run scriptboot; fi;" \
 			"fi;" \
 		"fi;" \
 		"if run slide; then true; else " \
-- 
2.20.1

[maemo-leste] [PATCH] Nokia RX-51: Do not try calling both ext2load and ext4load

[Pavel Machek]

On Mon 2020-11-30 20:10:34, Pali Roh?r wrote:
> Those two commands now doing same thing, reading from ext2/3/4 filesystem.
> So remove useless duplicated call.
> 
> Signed-off-by: Pali Roh?r <pali@kernel.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
http://www.livejournal.com/~pavelmachek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201230/53a6bfa1/attachment.sig>

[PATCH] Nokia RX-51: Do not try calling both ext2load and ext4load

[Lokesh Vutla]

On 01/12/20 12:40 am, Pali Roh?r wrote:
> Those two commands now doing same thing, reading from ext2/3/4 filesystem.
> So remove useless duplicated call.
> 
> Signed-off-by: Pali Roh?r <pali@kernel.org>


Applied to u-boot-ti/for-next branch

Thanks and regards,
Lokesh

> ---
>  include/configs/nokia_rx51.h | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
> index 6879f52a0c..3f2700d8e2 100644
> --- a/include/configs/nokia_rx51.h
> +++ b/include/configs/nokia_rx51.h
> @@ -169,8 +169,6 @@ int rx51_kp_getc(struct stdio_dev *sdev);
>  	"trymmcboot=if run switchmmc; then " \
>  			"setenv mmctype fat;" \
>  			"run trymmcallpartboot;" \
> -			"setenv mmctype ext2;" \
> -			"run trymmcallpartboot;" \
>  			"setenv mmctype ext4;" \
>  			"run trymmcallpartboot;" \
>  		"fi\0" \
> @@ -179,19 +177,10 @@ int rx51_kp_getc(struct stdio_dev *sdev);
>  	"preboot=setenv mmcnum 1; setenv mmcpart 1;" \
>  		"setenv mmcscriptfile bootmenu.scr;" \
>  		"if run switchmmc; then " \
> -			"setenv mmcdone true;" \
>  			"setenv mmctype fat;" \
> -			"if run scriptload; then true; else " \
> -				"setenv mmctype ext2;" \
> -				"if run scriptload; then true; else " \
> -					"setenv mmctype ext4;" \
> -					"if run scriptload; then true; else " \
> -						"setenv mmcdone false;" \
> -					"fi;" \
> -				"fi;" \
> -			"fi;" \
> -			"if ${mmcdone}; then " \
> -				"run scriptboot;" \
> +			"if run scriptload; then run scriptboot; else " \
> +				"setenv mmctype ext4;" \
> +				"if run scriptload; then run scriptboot; fi;" \
>  			"fi;" \
>  		"fi;" \
>  		"if run slide; then true; else " \
>