From: Eugen Hristev <eugen.hristev@microchip.com>
To: u-boot@lists.denx.de
Subject: [PATCH 34/34] ARM: dts: sama7g5ek: fix TXC pin configuration
Date: Thu, 3 Dec 2020 11:28:50 +0200 [thread overview]
Message-ID: <20201203092850.7909-35-eugen.hristev@microchip.com> (raw)
In-Reply-To: <20201203092850.7909-1-eugen.hristev@microchip.com>
From: Nicolas Ferre <nicolas.ferre@microchip.com>
TXC line is directly connected from the SoC to the KSZ9131 PHY. There
is a transient state on this signal, before configuring it to RGMII,
which leads to packet transmit being blocked.
Keeping a pull-up when muxing this pin as function A (G0_TXCK) fixes
the issue.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
arch/arm/dts/sama7g5ek.dts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/sama7g5ek.dts b/arch/arm/dts/sama7g5ek.dts
index 0812b0cc00..41818cc911 100644
--- a/arch/arm/dts/sama7g5ek.dts
+++ b/arch/arm/dts/sama7g5ek.dts
@@ -90,7 +90,7 @@
#address-cells = <1>;
#size-cells = <0>;
pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_gmac0_default>;
+ pinctrl-0 = <&pinctrl_gmac0_default &pinctrl_gmac0_txc_default>;
phy-mode = "rgmii-id";
status = "okay";
@@ -173,7 +173,6 @@
<PIN_PA28__G0_RX2>,
<PIN_PA29__G0_RX3>,
<PIN_PA15__G0_TXEN>,
- <PIN_PA24__G0_TXCK>,
<PIN_PA30__G0_RXCK>,
<PIN_PA18__G0_RXDV>,
<PIN_PA22__G0_MDC>,
@@ -182,6 +181,11 @@
bias-disable;
};
+ pinctrl_gmac0_txc_default: gmac0_txc_default {
+ pinmux = <PIN_PA24__G0_TXCK>;
+ bias-pull-up;
+ };
+
pinctrl_gmac1_default: gmac1_default {
pinmux = <PIN_PD30__G1_TXCK>,
<PIN_PD22__G1_TX0>,
--
2.25.1
prev parent reply other threads:[~2020-12-03 9:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 9:28 [PATCH 00/34] Sama7g5 Evaluation Kit support Eugen Hristev
2020-12-03 9:28 ` [PATCH 01/34] ARM: dts: sama7g5: add initial DT for sama7g5 SoC Eugen Hristev
2020-12-03 9:28 ` [PATCH 02/34] board: atmel: sama7g5ek: add initial support for sama7g5ek Eugen Hristev
2020-12-03 9:28 ` [PATCH 03/34] board: atmel: sama7g5ek: add SYS_MALLOC_F_LEN to SYS_INIT_SP_ADDR Eugen Hristev
2020-12-03 9:28 ` [PATCH 04/34] configs: sama7g5ek: set malloc pool to 68K Eugen Hristev
2020-12-03 9:28 ` [PATCH 05/34] configs: sama7g5ek: enable pll driver Eugen Hristev
2020-12-03 9:28 ` [PATCH 06/34] ARM: dts: sama7g5: move clock frequencies for xtals in board file Eugen Hristev
2020-12-03 9:28 ` [PATCH 07/34] ARM: dts: sama7g5: add slow rc and main rc oscillators Eugen Hristev
2020-12-03 9:28 ` [PATCH 08/34] ARM: dts: sama7g5: add u-boot, dm-pre-reloc bindings for xtals Eugen Hristev
2020-12-03 9:28 ` [PATCH 09/34] ARM: dts: sama7g5: add slow clock bindings Eugen Hristev
2020-12-03 9:28 ` [PATCH 10/34] ARM: dts: sama7g5: add PMC bindings Eugen Hristev
2020-12-03 9:28 ` [PATCH 11/34] ARM: dts: sama7g5: switch to " Eugen Hristev
2020-12-03 9:28 ` [PATCH 12/34] configs: sama7g5: enable CONFIG_CPU Eugen Hristev
2020-12-03 9:28 ` [PATCH 13/34] ARM: dts: sama7g5: add CPU bindings Eugen Hristev
2020-12-03 9:28 ` [PATCH 14/34] configs: sama7g5: use PIT64B Eugen Hristev
2020-12-03 9:28 ` [PATCH 15/34] ARM: dts: sama7g5: enable autoboot Eugen Hristev
2020-12-03 9:28 ` [PATCH 16/34] ARM: dts: sama7g5: add pit64b support Eugen Hristev
2020-12-03 9:28 ` [PATCH 17/34] ARM: dts: at91: sama7g5: add pinctrl node Eugen Hristev
2020-12-03 9:28 ` [PATCH 18/34] ARM: dts: at91: sama7g5ek: add pinctrl for sdmmc1 and flx3 Eugen Hristev
2020-12-03 9:28 ` [PATCH 19/34] configs: sama7g5ek: enable mii command Eugen Hristev
2020-12-03 9:28 ` [PATCH 20/34] ARM: dts: sama7g5: add GMAC0 Eugen Hristev
2020-12-03 9:28 ` [PATCH 21/34] ARM: dts: sama7g5: add GMAC1 Eugen Hristev
2020-12-03 9:28 ` [PATCH 22/34] board: atmel: sama7g5ek: increase arp timeout and retry count Eugen Hristev
2020-12-03 9:28 ` [PATCH 23/34] configs: sama7g5ek: enable support for KSZ9131 Eugen Hristev
2020-12-03 9:28 ` [PATCH 24/34] configs: sama7g5ek: enable CCF Eugen Hristev
2020-12-03 9:28 ` [PATCH 25/34] ARM: dts: at91: sama7g5: add assigned clocks for sdmmc1 Eugen Hristev
2020-12-03 9:28 ` [PATCH 26/34] ARM: dts: at91: sama7g5: add node for sdmmc0 Eugen Hristev
2020-12-03 9:28 ` [PATCH 27/34] ARM: dts: at91: sama7g5ek: enable sdmmc0 with pinctrl Eugen Hristev
2020-12-03 9:28 ` [PATCH 28/34] board: atmel: sama7g5ek: clean-up header bootcommand Eugen Hristev
2020-12-03 9:28 ` [PATCH 29/34] configs: sama7g5: add mmc config for sdmmc0 Eugen Hristev
2020-12-03 10:38 ` Jaehoon Chung
2020-12-03 10:47 ` Eugen.Hristev at microchip.com
2020-12-03 11:11 ` Jaehoon Chung
2020-12-03 11:20 ` Eugen.Hristev at microchip.com
2020-12-03 21:45 ` Jaehoon Chung
2020-12-04 7:00 ` Eugen.Hristev at microchip.com
2020-12-06 22:15 ` Jaehoon Chung
2020-12-03 9:28 ` [PATCH 30/34] ARM: dts: at91: sama7g5: add flexcom1 and i2c subnode Eugen Hristev
2020-12-03 9:28 ` [PATCH 31/34] ARM: dts: sama7g5ek: add i2c1 bus and eeproms Eugen Hristev
2020-12-03 9:28 ` [PATCH 32/34] board: atmel: sama7g5ek: add support for MAC address retreival Eugen Hristev
2020-12-03 9:28 ` [PATCH 33/34] configs: sama7g5ek: add i2c and eeprom Eugen Hristev
2020-12-03 9:28 ` Eugen Hristev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203092850.7909-35-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox