From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()
Date: Thu, 3 Dec 2020 11:59:11 -0500 [thread overview]
Message-ID: <20201203165911.GL32272@bill-the-cat> (raw)
In-Reply-To: <20201119192620.54872-1-andriy.shevchenko@linux.intel.com>
On Thu, Nov 19, 2020 at 09:26:20PM +0200, Andy Shevchenko wrote:
> It seems nobody tested the debug() option in spin_lock_irqsave().
> Currently, when #define DEBUG, it spoils the compiler with
>
> In file included from drivers/usb/dwc3/gadget.c:18:
> drivers/usb/dwc3/gadget.c: In function ?dwc3_gadget_set_selfpowered?:
> include/log.h:235:4: warning: ?flags? is used uninitialized in this function [-Wuninitialized]
> 235 | printf(pr_fmt(fmt), ##args); \
> | ^~~~~~
> drivers/usb/dwc3/gadget.c:1347:17: note: ?flags? was declared here
> 1347 | unsigned long flags;
> | ^~~~~
>
> and so on...
> Drop useless debug() call to make compiler happy.
>
> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h")
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201203/eb67f3e2/attachment.sig>
prev parent reply other threads:[~2020-12-03 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 19:26 [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave() Andy Shevchenko
2020-11-19 20:21 ` Andy Shevchenko
2020-11-20 13:42 ` Oleksandr Andrushchenko
2020-11-23 4:46 ` Heiko Schocher
2020-12-02 18:28 ` Andy Shevchenko
2020-12-02 18:37 ` Tom Rini
2020-12-02 18:53 ` Andy Shevchenko
2020-12-03 16:59 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203165911.GL32272@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox