* [PATCH] imx: ahab: fix implicit declaration warning
@ 2020-11-06 8:09 Oliver Graute
2020-11-06 8:09 ` [PATCH] imx: ahab: fix compiler warnings in debug Oliver Graute
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Oliver Graute @ 2020-11-06 8:09 UTC (permalink / raw)
To: u-boot
Fix the following warning:
arch/arm/mach-imx/imx8/ahab.c:105:3: warning: implicit declaration of function ?flush_dcache_range? [-Wimplicit-function-declaration]
flush_dcache_range(s, e);
^~~~~~~~~~~~~~~~~~
Include cpu_func.h header which declares the flush_dcache_range()
function.
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: uboot-imx <uboot-imx@nxp.com>
---
arch/arm/mach-imx/imx8/ahab.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/imx8/ahab.c b/arch/arm/mach-imx/imx8/ahab.c
index 5dbe1d56e0..abd648a60c 100644
--- a/arch/arm/mach-imx/imx8/ahab.c
+++ b/arch/arm/mach-imx/imx8/ahab.c
@@ -14,6 +14,7 @@
#include <asm/arch/sys_proto.h>
#include <asm/arch/image.h>
#include <console.h>
+#include <cpu_func.h>
DECLARE_GLOBAL_DATA_PTR;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] imx: ahab: fix compiler warnings in debug
2020-11-06 8:09 [PATCH] imx: ahab: fix implicit declaration warning Oliver Graute
@ 2020-11-06 8:09 ` Oliver Graute
2020-12-08 7:59 ` sbabic at denx.de
2020-11-06 8:09 ` [PATCH] imx: ahab: Fix compiler warnings in printf Oliver Graute
2020-12-08 7:59 ` [PATCH] imx: ahab: fix implicit declaration warning sbabic at denx.de
2 siblings, 1 reply; 6+ messages in thread
From: Oliver Graute @ 2020-11-06 8:09 UTC (permalink / raw)
To: u-boot
arch/arm/mach-imx/imx8/ahab.c: In function ?authenticate_os_container?:
arch/arm/mach-imx/imx8/ahab.c:96:9: warning: format ?%x? expects argument of type
?unsigned int?, but argument 9 has type ?ulong {aka long unsigned int}? [-Wformat=]
debug("img %d, dst 0x%x, src 0x%x, size 0x%x\n",
Fix those by using "%lu" specified.
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: uboot-imx <uboot-imx@nxp.com>
---
arch/arm/mach-imx/imx8/ahab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/imx8/ahab.c b/arch/arm/mach-imx/imx8/ahab.c
index abd648a60c..c77beb2b16 100644
--- a/arch/arm/mach-imx/imx8/ahab.c
+++ b/arch/arm/mach-imx/imx8/ahab.c
@@ -93,7 +93,7 @@ int authenticate_os_container(ulong addr)
sizeof(struct container_hdr) +
i * sizeof(struct boot_img_t));
- debug("img %d, dst 0x%x, src 0x%x, size 0x%x\n",
+ debug("img %d, dst 0x%x, src 0x%lux, size 0x%x\n",
i, (uint32_t) img->dst, img->offset + addr, img->size);
memcpy((void *)img->dst, (const void *)(img->offset + addr),
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] imx: ahab: Fix compiler warnings in printf
2020-11-06 8:09 [PATCH] imx: ahab: fix implicit declaration warning Oliver Graute
2020-11-06 8:09 ` [PATCH] imx: ahab: fix compiler warnings in debug Oliver Graute
@ 2020-11-06 8:09 ` Oliver Graute
2020-12-08 7:58 ` sbabic at denx.de
2020-12-08 7:59 ` [PATCH] imx: ahab: fix implicit declaration warning sbabic at denx.de
2 siblings, 1 reply; 6+ messages in thread
From: Oliver Graute @ 2020-11-06 8:09 UTC (permalink / raw)
To: u-boot
arch/arm/mach-imx/imx8/ahab.c:110:63: warning: format ?%x? expects
argument of type ?unsigned int?, but argument 2 has type ?u64 {aka long
long unsigned int}? [-Wformat=]
Fix those by using %llx
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: uboot-imx <uboot-imx@nxp.com>
---
arch/arm/mach-imx/imx8/ahab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/imx8/ahab.c b/arch/arm/mach-imx/imx8/ahab.c
index c77beb2b16..4bb7c46921 100644
--- a/arch/arm/mach-imx/imx8/ahab.c
+++ b/arch/arm/mach-imx/imx8/ahab.c
@@ -107,7 +107,7 @@ int authenticate_os_container(ulong addr)
/* Find the memreg and set permission for seco pt */
err = sc_rm_find_memreg(-1, &mr, s, e);
if (err) {
- printf("Error: can't find memreg for image load address 0x%x, error %d\n", img->dst, err);
+ printf("Error: can't find memreg for image load address 0x%llx, error %d\n", img->dst, err);
ret = -ENOMEM;
goto exit;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] imx: ahab: Fix compiler warnings in printf
2020-11-06 8:09 ` [PATCH] imx: ahab: Fix compiler warnings in printf Oliver Graute
@ 2020-12-08 7:58 ` sbabic at denx.de
0 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2020-12-08 7:58 UTC (permalink / raw)
To: u-boot
> arch/arm/mach-imx/imx8/ahab.c:110:63: warning: format ?%x? expects
> argument of type ?unsigned int?, but argument 2 has type ?u64 {aka long
> long unsigned int}? [-Wformat=]
> Fix those by using %llx
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: uboot-imx <uboot-imx@nxp.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: ahab: fix compiler warnings in debug
2020-11-06 8:09 ` [PATCH] imx: ahab: fix compiler warnings in debug Oliver Graute
@ 2020-12-08 7:59 ` sbabic at denx.de
0 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2020-12-08 7:59 UTC (permalink / raw)
To: u-boot
> arch/arm/mach-imx/imx8/ahab.c: In function ?authenticate_os_container?:
> arch/arm/mach-imx/imx8/ahab.c:96:9: warning: format ?%x? expects argument of type
> ?unsigned int?, but argument 9 has type ?ulong {aka long unsigned int}? [-Wformat=]
> debug("img %d, dst 0x%x, src 0x%x, size 0x%x\n",
> Fix those by using "%lu" specified.
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: uboot-imx <uboot-imx@nxp.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: ahab: fix implicit declaration warning
2020-11-06 8:09 [PATCH] imx: ahab: fix implicit declaration warning Oliver Graute
2020-11-06 8:09 ` [PATCH] imx: ahab: fix compiler warnings in debug Oliver Graute
2020-11-06 8:09 ` [PATCH] imx: ahab: Fix compiler warnings in printf Oliver Graute
@ 2020-12-08 7:59 ` sbabic at denx.de
2 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2020-12-08 7:59 UTC (permalink / raw)
To: u-boot
> Fix the following warning:
> arch/arm/mach-imx/imx8/ahab.c:105:3: warning: implicit declaration of function ?flush_dcache_range? [-Wimplicit-function-declaration]
> flush_dcache_range(s, e);
> ^~~~~~~~~~~~~~~~~~
> Include cpu_func.h header which declares the flush_dcache_range()
> function.
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: uboot-imx <uboot-imx@nxp.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-08 7:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-06 8:09 [PATCH] imx: ahab: fix implicit declaration warning Oliver Graute
2020-11-06 8:09 ` [PATCH] imx: ahab: fix compiler warnings in debug Oliver Graute
2020-12-08 7:59 ` sbabic at denx.de
2020-11-06 8:09 ` [PATCH] imx: ahab: Fix compiler warnings in printf Oliver Graute
2020-12-08 7:58 ` sbabic at denx.de
2020-12-08 7:59 ` [PATCH] imx: ahab: fix implicit declaration warning sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox