From mboxrd@z Thu Jan 1 00:00:00 1970 From: Torsten Duwe Date: Wed, 16 Dec 2020 14:22:03 +0100 Subject: [PATCH 1/2] lib: uuid: use RNG device if present In-Reply-To: <20201216104117.10836-2-matthias.bgg@kernel.org> References: <20201216104117.10836-1-matthias.bgg@kernel.org> <20201216104117.10836-2-matthias.bgg@kernel.org> Message-ID: <20201216142203.5a1db229@blackhole.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 16 Dec 2020 11:41:16 +0100 matthias.bgg at kernel.org wrote: > @@ -249,9 +250,22 @@ void gen_rand_uuid(unsigned char *uuid_bin) > { > u32 ptr[4]; > struct uuid *uuid = (struct uuid *)ptr; > - int i; > - > - srand(get_ticks() + rand()); > + int i, ret; > + struct udevice *devp; > + u8 randv = 0; > + > +#if defined(CONFIG_DM_RNG) > + ret = uclass_get_device(UCLASS_RNG, 0, &devp); > + if (ret) { > + ret = dm_rng_read(dev, randv, sizeof(randv)); ^ ^ same as patch 2/2 > + if (ret < 0) > + randv = 0; > + } > + if (randv) > + srand(randv); > + else > +#endif > + srand(get_ticks() + rand()); > > /* Set all fields randomly */ > for (i = 0; i < 4; i++)