From: matthias.bgg at kernel.org <matthias.bgg@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2 1/2] lib: uuid: use RNG device if present
Date: Wed, 16 Dec 2020 17:28:06 +0100 [thread overview]
Message-ID: <20201216162807.10685-2-matthias.bgg@kernel.org> (raw)
In-Reply-To: <20201216162807.10685-1-matthias.bgg@kernel.org>
From: Matthias Brugger <mbrugger@suse.com>
When calculating a random UUID we use a weak seed.
Use a RNG device if present to increase entropy.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
Changes in v2:
- fix dm_rng_read() parameters
- add missing include
lib/uuid.c | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/lib/uuid.c b/lib/uuid.c
index e62d5ca264..e3487380c3 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -15,6 +15,8 @@
#include <asm/io.h>
#include <part_efi.h>
#include <malloc.h>
+#include <dm/uclass.h>
+#include <rng.h>
/*
* UUID - Universally Unique IDentifier - 128 bits unique number.
@@ -249,9 +251,22 @@ void gen_rand_uuid(unsigned char *uuid_bin)
{
u32 ptr[4];
struct uuid *uuid = (struct uuid *)ptr;
- int i;
-
- srand(get_ticks() + rand());
+ int i, ret;
+ struct udevice *devp;
+ u8 randv = 0;
+
+#if defined(CONFIG_DM_RNG)
+ ret = uclass_get_device(UCLASS_RNG, 0, &devp);
+ if (ret) {
+ ret = dm_rng_read(devp, &randv, sizeof(randv));
+ if (ret < 0)
+ randv = 0;
+ }
+ if (randv)
+ srand(randv);
+ else
+#endif
+ srand(get_ticks() + rand());
/* Set all fields randomly */
for (i = 0; i < 4; i++)
--
2.29.2
next prev parent reply other threads:[~2020-12-16 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 16:28 [PATCH v2 0/2] Use RNG to get random behaviour matthias.bgg at kernel.org
2020-12-16 16:28 ` matthias.bgg at kernel.org [this message]
2020-12-18 8:37 ` [PATCH v2 1/2] lib: uuid: use RNG device if present Torsten Duwe
2020-12-18 9:10 ` mbrugger
2020-12-19 2:29 ` Simon Glass
2020-12-20 16:59 ` Torsten Duwe
2020-12-20 18:17 ` Simon Glass
2020-12-23 10:24 ` Torsten Duwe
2020-12-29 3:32 ` Simon Glass
2021-01-20 11:17 ` Matthias Brugger
2021-01-20 19:50 ` Simon Glass
2021-01-20 19:56 ` Matthias Brugger
2020-12-23 10:09 ` Matthias Brugger
2020-12-16 16:28 ` [PATCH v2 2/2] net: Use NDRNG device in srand_mac() matthias.bgg at kernel.org
2020-12-19 2:29 ` Simon Glass
2020-12-18 8:31 ` [PATCH v2 0/2] Use RNG to get random behaviour Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216162807.10685-2-matthias.bgg@kernel.org \
--to=matthias.bgg@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox