From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1 4/4] IOMUX: Stop dropped consoles
Date: Wed, 16 Dec 2020 20:04:13 +0200 [thread overview]
Message-ID: <20201216180413.18887-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20201216180413.18887-1-andriy.shevchenko@linux.intel.com>
When at some point environment shrinks we need to stop dropped devices.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
common/iomux.c | 25 ++++++++++++++++++++++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index 8a063563aa27..b6936317b12e 100644
--- a/common/iomux.c
+++ b/common/iomux.c
@@ -22,13 +22,19 @@ void iomux_printdevs(const int console)
printf("\n");
}
+static void iomux_console_stop(struct stdio_dev *dev)
+{
+ if (dev->stop)
+ dev->stop(dev);
+}
+
/* This tries to preserve the old list if an error occurs. */
int iomux_doenv(const int console, const char *arg)
{
char *console_args, *temp, **start;
int i, j, k, io_flag, cs_idx, repeat;
+ struct stdio_dev **cons_set, **old_set;
struct stdio_dev *dev;
- struct stdio_dev **cons_set;
console_args = strdup(arg);
if (console_args == NULL)
@@ -128,10 +134,23 @@ int iomux_doenv(const int console, const char *arg)
return 1;
}
- /* Works even if console_devices[console] is NULL. */
- free(console_devices[console]);
+ old_set = console_devices[console];
+ repeat = cd_count[console];
+
console_devices[console] = cons_set;
cd_count[console] = cs_idx;
+
+ /* Stop dropped consoles */
+ for (i = 0; i < repeat; i++) {
+ for (j = 0; j < cs_idx; j++) {
+ if (old_set[i] == cons_set[j])
+ break;
+ }
+ if (j == cs_idx)
+ iomux_console_stop(old_set[i]);
+ }
+
+ free(old_set);
return 0;
}
#endif /* CONSOLE_MUX */
--
2.29.2
next prev parent reply other threads:[~2020-12-16 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 18:04 [PATCH v1 1/4] IOMUX: Preserve console list if realloc() fails Andy Shevchenko
2020-12-16 18:04 ` [PATCH v1 2/4] IOMUX: Drop indentation level by removing redundant 'else' Andy Shevchenko
2020-12-16 18:04 ` [PATCH v1 3/4] IOMUX: Refactor iomux_doenv() in order to increase readability Andy Shevchenko
2020-12-16 18:04 ` Andy Shevchenko [this message]
2020-12-16 19:40 ` [PATCH v1 1/4] IOMUX: Preserve console list if realloc() fails Andy Shevchenko
2020-12-16 23:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216180413.18887-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox