From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 6/7] IOMUX: Drop indentation level by removing redundant 'else'
Date: Thu, 17 Dec 2020 01:16:23 +0200 [thread overview]
Message-ID: <20201216231624.9724-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20201216231624.9724-1-andriy.shevchenko@linux.intel.com>
Obviously the following has unnecessary indentation level in 'else' branch.
if (foo) {
...
return;
} else {
...
}
Drop indentation level by removing redundant 'else'.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: no changes
common/iomux.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index 51557d028029..8a063563aa27 100644
--- a/common/iomux.c
+++ b/common/iomux.c
@@ -126,12 +126,12 @@ int iomux_doenv(const int console, const char *arg)
if (cs_idx == 0) {
free(cons_set);
return 1;
- } else {
- /* Works even if console_devices[console] is NULL. */
- free(console_devices[console]);
- console_devices[console] = cons_set;
- cd_count[console] = cs_idx;
}
+
+ /* Works even if console_devices[console] is NULL. */
+ free(console_devices[console]);
+ console_devices[console] = cons_set;
+ cd_count[console] = cs_idx;
return 0;
}
#endif /* CONSOLE_MUX */
--
2.29.2
next prev parent reply other threads:[~2020-12-16 23:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 23:16 [PATCH v2 1/7] console: Introduce console_start() and console_stop() Andy Shevchenko
2020-12-16 23:16 ` [PATCH v2 2/7] console: Keep ->start() and ->stop() balanced Andy Shevchenko
2020-12-17 9:48 ` Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 3/7] IOMUX: move search_device() to console.h Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-21 12:01 ` Andy Shevchenko
2020-12-21 16:47 ` Simon Glass
2020-12-21 17:17 ` Andy Shevchenko
2020-12-21 17:33 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to increase readability Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-21 12:04 ` Andy Shevchenko
2020-12-21 16:47 ` Simon Glass
2020-12-16 23:16 ` Andy Shevchenko [this message]
2020-12-19 2:29 ` [PATCH v2 6/7] IOMUX: Drop indentation level by removing redundant 'else' Simon Glass
2020-12-16 23:16 ` [PATCH v2 7/7] IOMUX: Stop dropped consoles Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-19 2:29 ` [PATCH v2 1/7] console: Introduce console_start() and console_stop() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216231624.9724-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox