From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 7/7] IOMUX: Stop dropped consoles
Date: Thu, 17 Dec 2020 01:16:24 +0200 [thread overview]
Message-ID: <20201216231624.9724-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20201216231624.9724-1-andriy.shevchenko@linux.intel.com>
When at some point environment shrinks we need to stop dropped devices.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: rebased to use console_stop()
common/iomux.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index 8a063563aa27..4fe73c8cba8a 100644
--- a/common/iomux.c
+++ b/common/iomux.c
@@ -27,8 +27,8 @@ int iomux_doenv(const int console, const char *arg)
{
char *console_args, *temp, **start;
int i, j, k, io_flag, cs_idx, repeat;
+ struct stdio_dev **cons_set, **old_set;
struct stdio_dev *dev;
- struct stdio_dev **cons_set;
console_args = strdup(arg);
if (console_args == NULL)
@@ -128,10 +128,23 @@ int iomux_doenv(const int console, const char *arg)
return 1;
}
- /* Works even if console_devices[console] is NULL. */
- free(console_devices[console]);
+ old_set = console_devices[console];
+ repeat = cd_count[console];
+
console_devices[console] = cons_set;
cd_count[console] = cs_idx;
+
+ /* Stop dropped consoles */
+ for (i = 0; i < repeat; i++) {
+ for (j = 0; j < cs_idx; j++) {
+ if (old_set[i] == cons_set[j])
+ break;
+ }
+ if (j == cs_idx)
+ console_stop(console, old_set[i]);
+ }
+
+ free(old_set);
return 0;
}
#endif /* CONSOLE_MUX */
--
2.29.2
next prev parent reply other threads:[~2020-12-16 23:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 23:16 [PATCH v2 1/7] console: Introduce console_start() and console_stop() Andy Shevchenko
2020-12-16 23:16 ` [PATCH v2 2/7] console: Keep ->start() and ->stop() balanced Andy Shevchenko
2020-12-17 9:48 ` Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 3/7] IOMUX: move search_device() to console.h Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-21 12:01 ` Andy Shevchenko
2020-12-21 16:47 ` Simon Glass
2020-12-21 17:17 ` Andy Shevchenko
2020-12-21 17:33 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to increase readability Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-21 12:04 ` Andy Shevchenko
2020-12-21 16:47 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 6/7] IOMUX: Drop indentation level by removing redundant 'else' Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` Andy Shevchenko [this message]
2020-12-19 2:29 ` [PATCH v2 7/7] IOMUX: Stop dropped consoles Simon Glass
2020-12-19 2:29 ` [PATCH v2 1/7] console: Introduce console_start() and console_stop() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216231624.9724-7-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox