From: Torsten Duwe <duwe@lst.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 0/2] Use RNG to get random behaviour
Date: Fri, 18 Dec 2020 09:31:53 +0100 [thread overview]
Message-ID: <20201218093153.1294099e@blackhole> (raw)
In-Reply-To: <20201216162807.10685-1-matthias.bgg@kernel.org>
On Wed, 16 Dec 2020 17:28:05 +0100
matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
>
> For now bootp and uuid code use a weak seed for generating random
> data. U-Boot as support for RNG devices now, so we should change to
> code to use them if they are present. This will help mitigate issues
> like seen in CVE-2019-11690.
>
> Changes in v2:
> - fix dm_rng_read() parameters
> - add missing include
> - fix dm_rng_read() parameters
> - add missing include file
One more thing for both patches:
https://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation
If U-Boot also follows these, it should be
if (IS_ENABLED(CONFIG_DM_RNG) ) {
...
}
Instead of #if defined(...). AFAICS, it's easy to see for the compiler
that randv is constantly 0 if only the devp usage is made conditional.
That would also be more readable.
Torsten
prev parent reply other threads:[~2020-12-18 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 16:28 [PATCH v2 0/2] Use RNG to get random behaviour matthias.bgg at kernel.org
2020-12-16 16:28 ` [PATCH v2 1/2] lib: uuid: use RNG device if present matthias.bgg at kernel.org
2020-12-18 8:37 ` Torsten Duwe
2020-12-18 9:10 ` mbrugger
2020-12-19 2:29 ` Simon Glass
2020-12-20 16:59 ` Torsten Duwe
2020-12-20 18:17 ` Simon Glass
2020-12-23 10:24 ` Torsten Duwe
2020-12-29 3:32 ` Simon Glass
2021-01-20 11:17 ` Matthias Brugger
2021-01-20 19:50 ` Simon Glass
2021-01-20 19:56 ` Matthias Brugger
2020-12-23 10:09 ` Matthias Brugger
2020-12-16 16:28 ` [PATCH v2 2/2] net: Use NDRNG device in srand_mac() matthias.bgg at kernel.org
2020-12-19 2:29 ` Simon Glass
2020-12-18 8:31 ` Torsten Duwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218093153.1294099e@blackhole \
--to=duwe@lst.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox