[PATCH] tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH

[PATCH] tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH

[Bin Meng]

Use the dtc executable generated during the U-Boot build process for
mkimage. This removes the build dependency on the external dtc.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 tools/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/Kconfig b/tools/Kconfig
index b2f5012240..366a9f5f81 100644
--- a/tools/Kconfig
+++ b/tools/Kconfig
@@ -2,7 +2,7 @@ menu "Tools options"
 
 config MKIMAGE_DTC_PATH
 	string "Path to dtc binary for use within mkimage"
-	default "dtc"
+	default "scripts/dtc/dtc"
 	help
 	  The mkimage host tool will, in order to generate FIT images make
 	  calls to the dtc application in order to create the output.  In
-- 
2.25.1

[PATCH] tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH

[Bin Meng]

On Sun, Dec 20, 2020 at 9:21 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Use the dtc executable generated during the U-Boot build process for
> mkimage. This removes the build dependency on the external dtc.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  tools/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Ping?

[PATCH] tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH

[Tom Rini]

On Wed, Jan 06, 2021 at 08:39:56PM +0800, Bin Meng wrote:
> On Sun, Dec 20, 2020 at 9:21 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Use the dtc executable generated during the U-Boot build process for
> > mkimage. This removes the build dependency on the external dtc.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> >  tools/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Ping?

OK.  I _think_ this is wrong.  This changes the compiled in path to
"dtc" that mkimage will have.  We don't want the system-wide installed
"mkimage" tool to call out to "scripts/dtc/dtc", but either "dtc" (so
that normal PATH parsing works) or possibly a less-obvious path to the
system-wide dtc (based on my commit message about FreeBSD having it in
some other location).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210106/1cc926b5/attachment.sig>

[PATCH] tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH

[Bin Meng]

On Wed, Jan 6, 2021 at 9:24 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, Jan 06, 2021 at 08:39:56PM +0800, Bin Meng wrote:
> > On Sun, Dec 20, 2020 at 9:21 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > Use the dtc executable generated during the U-Boot build process for
> > > mkimage. This removes the build dependency on the external dtc.
> > >
> > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > ---
> > >
> > >  tools/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > Ping?
>
> OK.  I _think_ this is wrong.  This changes the compiled in path to
> "dtc" that mkimage will have.  We don't want the system-wide installed
> "mkimage" tool to call out to "scripts/dtc/dtc", but either "dtc" (so
> that normal PATH parsing works) or possibly a less-obvious path to the
> system-wide dtc (based on my commit message about FreeBSD having it in
> some other location).

Agreed. That's probably why commit 1f6049e2501b ("tools/mkimage: Make
the path to the dtc binary that mkimage calls configurable") was
introduced. Thanks!

Regards,
Bin