From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Mon, 21 Dec 2020 13:38:13 +0200 Subject: [PATCH 01/26] sandbox: serial: Move priv into a header file In-Reply-To: <20201219103947.1.I427a5dd4b053a0ee590f64f7a41ca4d3e6af26d8@changeid> References: <20201219174018.1114146-1-sjg@chromium.org> <20201219103947.1.I427a5dd4b053a0ee590f64f7a41ca4d3e6af26d8@changeid> Message-ID: <20201221113813.GK4077@smile.fi.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Dec 19, 2020 at 10:39:53AM -0700, Simon Glass wrote: > Move this struct into a header file so that dtoc can include it in its > dt-platdata.c file. Reviewed-by: Andy Shevchenko > Signed-off-by: Simon Glass > --- > > arch/sandbox/include/asm/serial.h | 30 ++++++++++++++++++++++++++++++ > drivers/serial/sandbox.c | 16 +--------------- > 2 files changed, 31 insertions(+), 15 deletions(-) > create mode 100644 arch/sandbox/include/asm/serial.h > > diff --git a/arch/sandbox/include/asm/serial.h b/arch/sandbox/include/asm/serial.h > new file mode 100644 > index 00000000000..bc82aebd0ea > --- /dev/null > +++ b/arch/sandbox/include/asm/serial.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright 2020 Google LLC > + * Written by Simon Glass > + */ > + > +#ifndef __asm_serial_h > +#define __asm_serial_h > + > +#include > + > +struct sandbox_serial_plat { > +#if CONFIG_IS_ENABLED(OF_PLATDATA) > + struct dtd_sandbox_serial dtplat; > +#endif > + int colour; /* Text colour to use for output, -1 for none */ > +}; > + > +/** > + * struct sandbox_serial_priv - Private data for this driver > + * > + * @buf: holds input characters available to be read by this driver > + */ > +struct sandbox_serial_priv { > + struct membuff buf; > + char serial_buf[16]; > + bool start_of_line; > +}; > + > +#endif /* __asm_serial_h */ > diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c > index a05c56458b0..19368ba2560 100644 > --- a/drivers/serial/sandbox.c > +++ b/drivers/serial/sandbox.c > @@ -17,25 +17,11 @@ > #include > #include > #include > +#include > #include > > DECLARE_GLOBAL_DATA_PTR; > > -struct sandbox_serial_plat { > - int colour; /* Text colour to use for output, -1 for none */ > -}; > - > -/** > - * struct sandbox_serial_priv - Private data for this driver > - * > - * @buf: holds input characters available to be read by this driver > - */ > -struct sandbox_serial_priv { > - struct membuff buf; > - char serial_buf[16]; > - bool start_of_line; > -}; > - > /** > * output_ansi_colour() - Output an ANSI colour code > * > -- > 2.29.2.684.gfbc64c5ab5-goog > -- With Best Regards, Andy Shevchenko