From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon, 21 Dec 2020 14:01:30 +0200
Subject: [PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails
In-Reply-To: <CAPnjgZ1zHSSroF7x03yrigu3F0=pf2Xoi0b5E=wrM9+h8kvZYQ@mail.gmail.com>
References: <20201216231624.9724-1-andriy.shevchenko@linux.intel.com>
 <20201216231624.9724-4-andriy.shevchenko@linux.intel.com>
 <CAPnjgZ1zHSSroF7x03yrigu3F0=pf2Xoi0b5E=wrM9+h8kvZYQ@mail.gmail.com>
Message-ID: <20201221120130.GO4077@smile.fi.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Dec 18, 2020 at 07:29:19PM -0700, Simon Glass wrote:
> On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > It's realloc() 101 to avoid `foo = realloc(foo, ...);` call
> > due to getting a memory leak.
> 
> Hmm I don't think I knew that...

When you use the same variable for the source and destination in case of NULL
the source gone.

It's okay to have

	foo = bar;
	bar = realloc(bar, ...);
	if (bar == NULL)
	...do something with foo if needed...

But it seems it's not the case here.

> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks!

-- 
With Best Regards,
Andy Shevchenko