[PATCH v3 4/8] spl: fit: Remove useless loop in spl_fit_get_image_name()

Alexandru Gagniuc
2020-12-23T14:44:08Z

When a desired configuration is not found, conf_node will have a
negative value. Thus the for loop will start at the root "/" node of
the image, print the "/description" property, and stop.

It appears the intent of the loop was to print the names of the
subnodes under "/configurations". We would need the offset to the
"/configurations" node, which is abstracted by fit_find_config_node().

This change agrees that abstracting the node offset is the correct
design, and we shouldn't be parsing the configurations manually. Thus
the loop in spl_fit_get_image_name() is useless. Remove it.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
common/spl/spl_fit.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
index 5a06e8a9db..adcd6e3fcd 100644
--- a/common/spl/spl_fit.c
+++ b/common/spl/spl_fit.c
@@ -88,18 +88,8 @@ static int spl_fit_get_image_name(const struct spl_fit_info *ctx,
bool found = true;

conf_node = fit_find_config_node(ctx->fit);
- if (conf_node < 0) {
-#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
- printf("No matching DT out of these options:\n");
- for (node = fdt_first_subnode(ctx->fit, conf_node);
- node >= 0;
- node = fdt_next_subnode(ctx->fit, node)) {
- name = fdt_getprop(ctx->fit, node, "description", &len);
- printf(" %s\n", name);
- }
-#endif
+ if (conf_node < 0)
return conf_node;
- }

name = fdt_getprop(ctx->fit, conf_node, type, &len);
if (!name) {
--
2.26.2