public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE
Date: Sat, 26 Dec 2020 22:04:09 +0100	[thread overview]
Message-ID: <20201226210409.28073-1-pali@kernel.org> (raw)

CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled
CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work.

Define this dependency in Kconfig and remove information about this
requirement from documentation file.

Signed-off-by: Pali Roh?r <pali@kernel.org>
---
 cmd/Kconfig            | 1 +
 doc/usage/bootmenu.rst | 5 -----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 1595de999b..02c28c68bd 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -279,6 +279,7 @@ source lib/efi_selftest/Kconfig
 config CMD_BOOTMENU
 	bool "bootmenu"
 	select MENU
+	select CFB_CONSOLE_ANSI if CFB_CONSOLE
 	help
 	  Add an ANSI terminal boot menu command.
 
diff --git a/doc/usage/bootmenu.rst b/doc/usage/bootmenu.rst
index 1f094ad6ed..1016ac8ceb 100644
--- a/doc/usage/bootmenu.rst
+++ b/doc/usage/bootmenu.rst
@@ -88,8 +88,3 @@ To run the bootmenu at startup add these additional settings::
     CONFIG_AUTOBOOT_KEYED=y
     CONFIG_BOOTDELAY=30
     CONFIG_AUTOBOOT_MENU_SHOW=y
-
-When you intend to use the bootmenu on a color frame buffer console,
-make sure to additionally define::
-
-    CONFIG_CFB_CONSOLE_ANSI=y
-- 
2.20.1

             reply	other threads:[~2020-12-26 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26 21:04 Pali Rohár [this message]
2020-12-29  3:32 ` [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE Simon Glass
2020-12-29 10:42   ` Heinrich Schuchardt
2020-12-29 11:26     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201226210409.28073-1-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox