From: Peter Robinson <pbrobinson@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH] sunxi: don't define MACPWR and SATAPWR to empty strings
Date: Mon, 18 Jan 2021 00:18:23 +0000 [thread overview]
Message-ID: <20210118001823.243392-1-pbrobinson@gmail.com> (raw)
There's checks in board/sunxi/board.c if either MACPWR or SATAPWR are
defined and they are defined by default to a empty string which means
on vast majority of AllWinner boards when they're not required the
code is still run and with SATAPWR we even get an unnecessary 500ms
delay booting. So let's not define a default for these options so the
code is only run for boards that need it.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
arch/arm/mach-sunxi/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index 49ef217f08..a566e10315 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -578,7 +578,6 @@ config OLD_SUNXI_KERNEL_COMPAT
config MACPWR
string "MAC power pin"
- default ""
help
Set the pin used to power the MAC. This takes a string in the format
understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
@@ -969,7 +968,6 @@ endchoice
config SATAPWR
string "SATA power pin"
- default ""
help
Set the pins used to power the SATA. This takes a string in the
format understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of
--
2.29.2
next reply other threads:[~2021-01-18 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 0:18 Peter Robinson [this message]
2021-01-18 12:28 ` [PATCH] sunxi: don't define MACPWR and SATAPWR to empty strings André Przywara
2021-01-19 1:05 ` Andre Przywara
2021-01-19 15:01 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118001823.243392-1-pbrobinson@gmail.com \
--to=pbrobinson@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox