From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: CRASH caused by: [PATCH 06/10] setexpr: Add some tests for buffer overflow and backref
Date: Tue, 19 Jan 2021 14:45:41 -0500 [thread overview]
Message-ID: <20210119194541.GI9782@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1979T7T7mKK7i58RDxBHVpSeC0+coPse117XwSnnBfkg@mail.gmail.com>
On Tue, Jan 19, 2021 at 11:06:18AM -0700, Simon Glass wrote:
> Hi Heinrich,
>
> On Sun, 17 Jan 2021 at 15:52, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > On 11/1/20 10:15 PM, Simon Glass wrote:
> > > Add tests to check for buffer overflow using simple replacement as well
> > > as back references. At present these don't fully pass.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > cmd/setexpr.c | 21 +++--------
> > > include/command.h | 17 +++++++++
> > > test/cmd/setexpr.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 110 insertions(+), 17 deletions(-)
>
> Yes this is intended for sandbox.
>
> Do you really want to run this test on a board? If the compiler is
> working, then the sandbox test should be enough.
>
> I can certainly update it to run on boards, but that was not the intent.
I think it is good to run tests on hardware when there's no reason not
to. It ends up adding to the "if we're up and doing stuff for a while,
is the platform stable?" form of testing, which is harder to replicate
but useful at times.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210119/29f4b206/attachment.sig>
next prev parent reply other threads:[~2021-01-19 19:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 21:15 [PATCH 00/10] setexpr: Correct various bugs and add tests plus string support Simon Glass
2020-11-01 21:15 ` [PATCH 01/10] test: Add some tests for setexpr Simon Glass
2020-12-02 21:22 ` Tom Rini
2020-11-01 21:15 ` [PATCH 02/10] command: Add constants for cmd_get_data_size string / error Simon Glass
2020-12-02 21:22 ` Tom Rini
2020-11-01 21:15 ` [PATCH 03/10] setexpr: Add explicit support for 32- and 64-bit ints Simon Glass
2020-12-02 21:22 ` Tom Rini
2020-11-01 21:15 ` [PATCH 04/10] test: Add some setexpr regex tests Simon Glass
2020-12-02 21:22 ` Tom Rini
2020-11-01 21:15 ` [PATCH 05/10] setexpr: Split the core logic into its own function Simon Glass
2020-12-02 21:22 ` Tom Rini
2020-11-01 21:15 ` [PATCH 06/10] setexpr: Add some tests for buffer overflow and backref Simon Glass
2020-12-02 21:23 ` Tom Rini
2021-01-17 22:52 ` CRASH caused by: " Heinrich Schuchardt
2021-01-19 18:06 ` Simon Glass
2021-01-19 19:07 ` Heinrich Schuchardt
2021-01-19 19:45 ` Tom Rini [this message]
2021-01-20 0:17 ` Simon Glass
2020-11-01 21:15 ` [PATCH 07/10] setexpr: Correct dropping of final unmatched string Simon Glass
2020-12-02 21:23 ` Tom Rini
2020-11-01 21:15 ` [PATCH 08/10] setexpr: Correct buffer overflow bug and enable tests Simon Glass
2020-12-02 21:23 ` Tom Rini
2020-11-01 21:15 ` [PATCH 09/10] setexpr: Convert to use a struct for values Simon Glass
2020-12-02 21:23 ` Tom Rini
2020-11-01 21:15 ` [PATCH 10/10] setexpr: Add support for strings Simon Glass
2020-11-01 23:08 ` Marek Behun
2020-11-03 15:12 ` Simon Glass
2020-11-03 16:30 ` Marek Behun
2020-11-05 16:49 ` Wolfgang Denk
2020-11-05 17:27 ` Simon Glass
2020-11-06 20:58 ` Tom Rini
2020-11-06 21:48 ` Simon Glass
2020-11-05 16:47 ` Wolfgang Denk
2020-11-05 17:27 ` Simon Glass
2020-11-05 17:50 ` Marek Behun
2020-11-05 19:10 ` Wolfgang Denk
2020-11-05 20:15 ` Simon Glass
2020-12-02 21:23 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119194541.GI9782@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox