From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying
Date: Wed, 20 Jan 2021 16:46:38 -0500 [thread overview]
Message-ID: <20210120214638.GC9782@bill-the-cat> (raw)
In-Reply-To: <20201031010752.23974-3-wqu@suse.com>
On Sat, Oct 31, 2020 at 09:07:50AM +0800, Qu Wenruo wrote:
> In __btrfs_map_block() we do a int * int and assign it to u64.
> This is not safe as the result (int * int) is still evaluated as (int)
> thus it can overflow.
>
> Convert one of the multiplier to u64 to prevent such problem.
>
> In real world, this should not cause problem as we have device number
> limit thus it won't go beyond 4G for a single stripe.
>
> But it's harder to teach coverity about all these hidden limits, so just
> fix the possible overflow.
>
> Reported-by: Coverity CID 312957
> Reported-by: Coverity CID 312948
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210120/b7766dfc/attachment-0001.sig>
next prev parent reply other threads:[~2021-01-20 21:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 1:07 [PATCH 0/4] fs: btrfs: coverity fixes Qu Wenruo
2020-10-31 1:07 ` [PATCH 1/4] fs: btrfs: inode: handle uninitialized type before returning it Qu Wenruo
2020-11-01 22:59 ` Marek Behun
2020-11-20 1:36 ` Tom Rini
2020-10-31 1:07 ` [PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying Qu Wenruo
2020-11-01 23:02 ` Marek Behun
2020-11-02 0:20 ` Qu Wenruo
2020-11-02 1:06 ` Qu Wenruo
2021-01-20 21:46 ` Tom Rini [this message]
2020-10-31 1:07 ` [PATCH 3/4] fs: btrfs: initialize @ret to 0 to prevent uninitialized return value Qu Wenruo
2020-11-01 23:03 ` Marek Behun
2020-11-20 1:36 ` Tom Rini
2020-10-31 1:07 ` [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy Qu Wenruo
2020-11-01 23:06 ` Marek Behun
2020-11-02 0:27 ` Qu Wenruo
2020-11-02 7:24 ` Marek Behun
2020-11-02 7:27 ` Qu Wenruo
2020-11-02 20:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120214638.GC9782@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox