[PATCH v2 4/4] mkimge: Reject signing-related flags without FIT_SIGNATURE

Simon Glass
2020-12-12T15:39:43Z

Hi,

On Tue, 8 Dec 2020 at 08:38, Philippe REYNES
<philippe.reynes@softathome.com> wrote:
>
> Hi Joel
>
>
> Le 08/12/2020 ? 05:12, Joel Stanley a ?crit :
> > When CONFIG_FIT_SIGNATURE=n the signing options are not available. If a
> > user is careful they will notice this when looking at the help output.
> >
> > If they are not careful they will waste several hours wondering why
> > their FIT doesn't contain a /signature node, as mkimage will silently
> > ingore the signing related options.
> >
> > Make it obvious that the commands don't work by removing them from the
> > getopt opt_string.
> >
> > $ mkimage -f machine.its -k keys -K u-boot-pubkey.dtb -r image.fit
> > mkimage: invalid option -- 'k'
> > Error: Invalid option
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > --
> > v2: Leave padding related options in the CONFIG_FIT_SIGNATURE=y optargs
> > ---
> > tools/mkimage.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >

I have somehow missed these patches on the mailing list. I'm not sure
why, but I'm not going to review them as is.

Regards,
Simon