public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH] tools: Remove #include <version.h>
Date: Wed, 27 Jan 2021 16:34:24 +0100	[thread overview]
Message-ID: <20210127153424.4650-1-pali@kernel.org> (raw)

Header file version.h includes also autogenerated file timestamp.h which
is recompiled on every time when SOURCE_DATE_EPOCH change.

Tools do not use build time therefore they do not have to include
timestamp.h file.

This change prevents recompiling tools every time when SOURCE_DATE_EPOCH
changes.

Signed-off-by: Pali Roh?r <pali@kernel.org>
---
 tools/dumpimage.c  | 2 +-
 tools/mkenvimage.c | 2 +-
 tools/mkimage.c    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/dumpimage.c b/tools/dumpimage.c
index e5481435a7..54c2517c9e 100644
--- a/tools/dumpimage.c
+++ b/tools/dumpimage.c
@@ -7,7 +7,7 @@
 
 #include "dumpimage.h"
 #include <image.h>
-#include <version.h>
+#include "generated/version_autogenerated.h"
 
 static void usage(void);
 
diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
index b05f83415f..6482ca6ee9 100644
--- a/tools/mkenvimage.c
+++ b/tools/mkenvimage.c
@@ -23,7 +23,7 @@
 
 #include "compiler.h"
 #include <u-boot/crc.h>
-#include <version.h>
+#include "generated/version_autogenerated.h"
 
 #define CRC_SIZE sizeof(uint32_t)
 
diff --git a/tools/mkimage.c b/tools/mkimage.c
index 68d5206cb4..d5e274c504 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -11,7 +11,7 @@
 #include "mkimage.h"
 #include "imximage.h"
 #include <image.h>
-#include <version.h>
+#include "generated/version_autogenerated.h"
 
 static void copy_file(int, const char *, int);
 
-- 
2.20.1

             reply	other threads:[~2021-01-27 15:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 15:34 Pali Rohár [this message]
2021-02-01 20:43 ` [PATCH] tools: Remove #include <version.h> Simon Glass
2021-02-01 21:20 ` Tom Rini
2021-02-03  0:34   ` Pali Rohár
2021-02-03 11:10   ` Pali Rohár
2021-02-25  1:05     ` Pali Rohár
2021-02-25 15:37       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127153424.4650-1-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox