From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3] net: e1000: Use virt_to_phys() instead of pci_virt_to_mem()
Date: Wed, 27 Jan 2021 14:21:41 -0500 [thread overview]
Message-ID: <20210127192141.GE7530@bill-the-cat> (raw)
In-Reply-To: <20201116170230.1148457-2-sr@denx.de>
On Mon, Nov 16, 2020 at 06:02:29PM +0100, Stefan Roese wrote:
> Using (dm_)pci_virt_to_mem() is incorrect to translate the virtual
> address in local DRAM to a physical address. The correct macro here
> is virt_to_phys() so switch to using this macro.
>
> As virt_to_bus() is now not used any more, this patch also removes
> both definitions (DM and non-DM).
>
> This issue was detected while testing the e1000 driver on the MIPS
> Octeon III platform, which needs address translation.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Aaron Williams <awilliams@marvell.com>
> Cc: Chandrakala Chavva <cchavva@marvell.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210127/9b77d515/attachment.sig>
next prev parent reply other threads:[~2021-01-27 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:02 [PATCH 1/3] net: e1000: Remove unused bus_to_phys() macro Stefan Roese
2020-11-16 17:02 ` [PATCH 2/3] net: e1000: Use virt_to_phys() instead of pci_virt_to_mem() Stefan Roese
2021-01-27 19:21 ` Tom Rini [this message]
2020-11-16 17:02 ` [PATCH 3/3] net: e1000: Add missing address translations Stefan Roese
2021-01-27 19:21 ` Tom Rini
2021-01-27 19:21 ` [PATCH 1/3] net: e1000: Remove unused bus_to_phys() macro Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127192141.GE7530@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox