From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 28 Jan 2021 18:57:01 -0500 Subject: [PATCH] common: fit-sig: Fix error message in fit_config_verify_sig() In-Reply-To: <20210111144658.620037-1-mr.nuke.me@gmail.com> References: <20210111144658.620037-1-mr.nuke.me@gmail.com> Message-ID: <20210128235701.GF7530@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jan 11, 2021 at 08:46:58AM -0600, Alexandru Gagniuc wrote: > In fit_config_verify_sig(), when no 'signature*' subnode exists in > the configuration node, the fdt_for_each_subnode() loop is a no-op. > Therefore, no error flags are set, and 'err_,sg' is not populated > with an error string. This is incorrect behavior. > > Populate err_msg to indicate that no 'signature' is found, before > entering the loop. The first call to fit_image_verify_sig() will > override clear err_msg, or set it to a more specific message. > > Signed-off-by: Alexandru Gagniuc > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: