public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] autoboot: fix illegal memory access when stop key and delay key are empty
Date: Thu, 28 Jan 2021 18:58:52 -0500	[thread overview]
Message-ID: <20210128235852.GW7530@bill-the-cat> (raw)
In-Reply-To: <HK2PR04MB3891CBB4241D01AC35808CA181A70@HK2PR04MB3891.apcprd04.prod.outlook.com>

On Fri, Jan 15, 2021 at 03:11:49AM +0000, Yuezhang.Mo at sony.com wrote:

> If both stop key and delay key are empty, the length of these
> keys is 0. The subtraction operation will cause the u_int type
> variable to overflow, will cause illegal memory access in key
> input loop.
> 
> This commit fixes this bug by using int type instead of u_init.
> Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210128/cee6e92b/attachment.sig>

      parent reply	other threads:[~2021-01-28 23:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  3:11 [PATCH] autoboot: fix illegal memory access when stop key and delay key are empty Yuezhang.Mo at sony.com
2021-01-15 12:19 ` Heinrich Schuchardt
2021-01-18  5:22   ` Andy.Wu at sony.com
2021-01-18  5:38     ` Andy.Wu at sony.com
2021-01-18  7:37       ` Heinrich Schuchardt
2021-01-28 23:58 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128235852.GW7530@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox