From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] tools: Remove #include <version.h>
Date: Mon, 1 Feb 2021 16:20:18 -0500 [thread overview]
Message-ID: <20210201212018.GC10169@bill-the-cat> (raw)
In-Reply-To: <20210127153424.4650-1-pali@kernel.org>
On Wed, Jan 27, 2021 at 04:34:24PM +0100, Pali Roh?r wrote:
> Header file version.h includes also autogenerated file timestamp.h which
> is recompiled on every time when SOURCE_DATE_EPOCH change.
>
> Tools do not use build time therefore they do not have to include
> timestamp.h file.
>
> This change prevents recompiling tools every time when SOURCE_DATE_EPOCH
> changes.
>
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> ---
> tools/dumpimage.c | 2 +-
> tools/mkenvimage.c | 2 +-
> tools/mkimage.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/dumpimage.c b/tools/dumpimage.c
> index e5481435a7..54c2517c9e 100644
> --- a/tools/dumpimage.c
> +++ b/tools/dumpimage.c
> @@ -7,7 +7,7 @@
>
> #include "dumpimage.h"
> #include <image.h>
> -#include <version.h>
> +#include "generated/version_autogenerated.h"
>
> static void usage(void);
>
I don't know if I really like this approach. It also seems inconsistent
as we have for example tools/fit-image.c that has content from
generated/version_autogenerated.h but wasn't changed by this patch (nor
the rest of the series).
I think a bit more invasive approach is required here. I like the
<version_string.h> approach you used elsewhere, and as best I can see,
the only place U_BOOT_VERSION_STRING, which is where we have the
timestamp itself, is used is cmd/version.c (and defined in version.h).
We should isolate the file that has the date such that it's only
in one file and referenced in one file. This means probably removing
the version_string global from arch/{powerpc,m68k} and dropping __weak
from cmd/version.c and seeing what happens, as well.
Do you see where I'm thinking with this, or do I need to try and explain
a bit more? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210201/85338a69/attachment.sig>
next prev parent reply other threads:[~2021-02-01 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 15:34 [PATCH] tools: Remove #include <version.h> Pali Rohár
2021-02-01 20:43 ` Simon Glass
2021-02-01 21:20 ` Tom Rini [this message]
2021-02-03 0:34 ` Pali Rohár
2021-02-03 11:10 ` Pali Rohár
2021-02-25 1:05 ` Pali Rohár
2021-02-25 15:37 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201212018.GC10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox