From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Wed, 3 Feb 2021 14:41:40 +0100 Subject: [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse() In-Reply-To: <062bada8-1acf-2af1-38aa-54b915d72c65@samsung.com> References: <20210202173724.28394-1-marek.behun@nic.cz> <062bada8-1acf-2af1-38aa-54b915d72c65@samsung.com> Message-ID: <20210203144140.3c76b442@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 3 Feb 2021 08:32:45 +0900 Jaehoon Chung wrote: > On 2/3/21 2:37 AM, Marek Beh?n wrote: > > This is needed to parse more capabilities such as `non-removable`. > > > > Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused > > a regression on Turris Omnia, because mv_sdhci driver did not fill out > > host_caps from device-tree. > > > > Signed-off-by: Marek Beh?n > > Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") > > I don't think that this patch is for fixing its commit. > > Best Regards, > Jaehoon Chung Commit da18c62b6e6a causes the regression. The Fixes tag, as I understand, should link to commit with which the regression first occured, so that if someone wanted to backport my patch to previous version of U-Boot, they would know that they only have to do it if their repository contains that commit. Marek