From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Sat, 6 Feb 2021 14:49:41 +0100 Subject: [RESEND PATCH 01/16] serial: usbtty: Fix puts function In-Reply-To: <20210205191212.7644-2-pali@kernel.org> References: <20210205191212.7644-1-pali@kernel.org> <20210205191212.7644-2-pali@kernel.org> Message-ID: <20210206144941.0b3a6645@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 5 Feb 2021 20:11:57 +0100 Pali Roh?r wrote: > This function has incorrect implementation of prepending CR prior LF. > Without this patch it prepended CR prior whole string which is going > to be written and let LF without leading CR. Fix this issue by > inserting CR at correct place to make output on usbtty serial console > more readable. > > Signed-off-by: Pali Roh?r > --- > drivers/serial/usbtty.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c > index f1c1a260da..02f8edf200 100644 > --- a/drivers/serial/usbtty.c > +++ b/drivers/serial/usbtty.c > @@ -500,8 +500,8 @@ void usbtty_puts(struct stdio_dev *dev, const > char *str) n = next_nl_pos (str); > > if (str[n] == '\n') { > - __usbtty_puts("\r", 1); > - __usbtty_puts(str, n + 1); > + __usbtty_puts(str, n); > + __usbtty_puts("\r\n", 2); > str += (n + 1); > len -= (n + 1); > } else { Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: