From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [RESEND PATCH 11/16] usb: gadget: Use dbg_ep0() macro instead of serial_printf()
Date: Sat, 6 Feb 2021 16:19:58 +0100 [thread overview]
Message-ID: <20210206161958.7208a1e2@jawa> (raw)
In-Reply-To: <20210205191212.7644-12-pali@kernel.org>
On Fri, 5 Feb 2021 20:12:07 +0100
Pali Roh?r <pali@kernel.org> wrote:
> All debug messages from ep0.c except a few are printed by dbg_ep0()
> macro. So for remaining few exception use also dbg_ep0() instead of
> serial_printf().
Reviewed-by: Lukasz Majewski <lukma@denx.de>
>
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> ---
> drivers/usb/gadget/ep0.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/gadget/ep0.c b/drivers/usb/gadget/ep0.c
> index 457679f0a4..6624f61b76 100644
> --- a/drivers/usb/gadget/ep0.c
> +++ b/drivers/usb/gadget/ep0.c
> @@ -294,7 +294,7 @@ static int ep0_get_descriptor (struct
> usb_device_instance *device, {
> struct usb_string_descriptor
> *string_descriptor; if (!(string_descriptor = usbd_get_string
> (index))) {
> - serial_printf("Invalid string index
> %d\n", index);
> + dbg_ep0(0, "Invalid string index
> %d\n", index); return -1;
> }
> dbg_ep0(3, "string_descriptor: %p length
> %d", string_descriptor, string_descriptor->bLength); @@ -302,14
> +302,14 @@ static int ep0_get_descriptor (struct usb_device_instance
> *device, } break;
> case USB_DESCRIPTOR_TYPE_INTERFACE:
> - serial_printf("USB_DESCRIPTOR_TYPE_INTERFACE - error not
> implemented\n");
> + dbg_ep0(2, "USB_DESCRIPTOR_TYPE_INTERFACE - error
> not implemented\n"); return -1;
> case USB_DESCRIPTOR_TYPE_ENDPOINT:
> - serial_printf("USB_DESCRIPTOR_TYPE_ENDPOINT - error
> not implemented\n");
> + dbg_ep0(2, "USB_DESCRIPTOR_TYPE_ENDPOINT - error not
> implemented\n"); return -1;
> case USB_DESCRIPTOR_TYPE_HID:
> {
> - serial_printf("USB_DESCRIPTOR_TYPE_HID -
> error not implemented\n");
> + dbg_ep0(2, "USB_DESCRIPTOR_TYPE_HID - error
> not implemented\n"); return -1; /* unsupported at this time */
> #if 0
> int bNumInterface =
> @@ -338,7 +338,7 @@ static int ep0_get_descriptor (struct
> usb_device_instance *device, break;
> case USB_DESCRIPTOR_TYPE_REPORT:
> {
> - serial_printf("USB_DESCRIPTOR_TYPE_REPORT -
> error not implemented\n");
> + dbg_ep0(2, "USB_DESCRIPTOR_TYPE_REPORT -
> error not implemented\n"); return -1; /* unsupported at this
> time */ #if 0
> int bNumInterface =
> @@ -531,7 +531,7 @@ int ep0_recv_setup (struct urb *urb)
> le16_to_cpu
> (request->wValue) & 0xff);
> case USB_REQ_GET_CONFIGURATION:
> - serial_printf("get config %d\n",
> device->configuration);
> + dbg_ep0(2, "get config %d\n",
> device->configuration); return ep0_get_one (device, urb,
> device->configuration);
>
> @@ -621,14 +621,14 @@ int ep0_recv_setup (struct urb *urb)
> device->interface = device->alternate = 0;
>
> /*dbg_ep0(2, "set configuration: %d",
> device->configuration); */
> - /*serial_printf("DEVICE_CONFIGURED..
> event?\n"); */
> + /*dbg_ep0(2, "DEVICE_CONFIGURED..
> event?\n"); */ return 0;
>
> case USB_REQ_SET_INTERFACE:
> device->interface = le16_to_cpu
> (request->wIndex); device->alternate = le16_to_cpu (request->wValue);
> /*dbg_ep0(2, "set interface: %d alternate:
> %d", device->interface, device->alternate); */
> - serial_printf("DEVICE_SET_INTERFACE..
> event?\n");
> + dbg_ep0(2, "DEVICE_SET_INTERFACE..
> event?\n"); return 0;
>
> case USB_REQ_GET_STATUS:
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210206/665389e2/attachment.sig>
next prev parent reply other threads:[~2021-02-06 15:19 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 19:11 [RESEND PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2021-02-05 19:11 ` [RESEND PATCH 01/16] serial: usbtty: Fix puts function Pali Rohár
2021-02-06 13:49 ` Lukasz Majewski
2021-02-05 19:11 ` [RESEND PATCH 02/16] serial: usbtty: Send urb data in correct order Pali Rohár
2021-02-06 13:56 ` Lukasz Majewski
2021-02-05 19:11 ` [RESEND PATCH 03/16] usb: musb: Fix compilation of gadget code Pali Rohár
2021-02-06 13:57 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 04/16] usb: musb: Always clear the data toggle bit when configuring ep Pali Rohár
2021-02-06 13:58 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 05/16] usb: musb: Fix configuring FIFO for endpoints Pali Rohár
2021-02-06 8:58 ` Pavel Machek
2021-02-06 14:01 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 06/16] usb: musb: Read value of PERI_RXCSR to 16bit variable Pali Rohár
2021-02-06 14:01 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 07/16] usb: musb: Fix transmission of bigger buffers Pali Rohár
2021-02-06 14:07 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 08/16] usb: musb: Fix receiving " Pali Rohár
2021-02-06 14:15 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 09/16] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand Pali Rohár
2021-02-06 14:17 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 10/16] usb: musb: Ensure that we set musb dynamic FIFO buffer for every endpoint Pali Rohár
2021-02-06 9:04 ` Pavel Machek
2021-02-06 15:18 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 11/16] usb: gadget: Use dbg_ep0() macro instead of serial_printf() Pali Rohár
2021-02-06 15:19 ` Lukasz Majewski [this message]
2021-02-05 19:12 ` [RESEND PATCH 12/16] arm: omap3: Compile lowlevel_init() function only when it is used Pali Rohár
2021-02-06 15:21 ` Lukasz Majewski
2021-02-06 15:40 ` Marek Vasut
2021-02-06 15:45 ` Pali Rohár
2021-02-06 16:50 ` Marek Vasut
2021-02-07 13:50 ` Pali Rohár
2021-02-07 14:33 ` Marek Vasut
2021-02-05 19:12 ` [RESEND PATCH 13/16] arm: omap3: Compile s_init() " Pali Rohár
2021-02-06 15:21 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 14/16] Nokia RX-51: Remove function set_muxconf_regs() Pali Rohár
2021-02-06 15:22 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 15/16] Nokia RX-51: Move content of rx51.h to rx51.c Pali Rohár
2021-02-06 15:23 ` Lukasz Majewski
2021-02-05 19:12 ` [RESEND PATCH 16/16] Nokia RX-51: Enable usbtty serial console by default Pali Rohár
2021-02-06 9:10 ` Pavel Machek
2021-02-06 15:24 ` Lukasz Majewski
2021-02-07 13:50 ` [RESEND v2 PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 01/16] serial: usbtty: Fix puts function Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 02/16] serial: usbtty: Send urb data in correct order Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 03/16] usb: musb: Fix compilation of gadget code Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 04/16] usb: musb: Always clear the data toggle bit when configuring ep Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 05/16] usb: musb: Fix configuring FIFO for endpoints Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 06/16] usb: musb: Read value of PERI_RXCSR to 16bit variable Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 07/16] usb: musb: Fix transmission of bigger buffers Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 08/16] usb: musb: Fix receiving " Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 09/16] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 10/16] usb: musb: Ensure that we set musb dynamic FIFO buffer for every endpoint Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 11/16] usb: gadget: Use dbg_ep0() macro instead of serial_printf() Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 12/16] arm: omap3: Compile lowlevel_init() function only when it is used Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 13/16] arm: omap3: Compile s_init() " Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 14/16] Nokia RX-51: Remove function set_muxconf_regs() Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 15/16] Nokia RX-51: Move content of rx51.h to rx51.c Pali Rohár
2021-02-07 13:50 ` [RESEND v2 PATCH 16/16] Nokia RX-51: Enable usbtty serial console by default Pali Rohár
2021-02-20 10:50 ` [AZURE FIX RESEND " Pali Rohár
2021-02-08 22:15 ` [RESEND v2 PATCH 00/16] Nokia RX-51: Fix USB TTY console and enable it Lukasz Majewski
2021-02-08 22:21 ` Pali Rohár
2021-02-08 22:34 ` Pali Rohár
2021-02-08 22:45 ` Marek Vasut
2021-02-08 22:54 ` Pali Rohár
2021-02-13 10:20 ` Pali Rohár
2021-02-16 8:28 ` Lukasz Majewski
2021-02-19 0:38 ` Pali Rohár
2021-02-20 8:20 ` Lukasz Majewski
2021-02-20 10:54 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210206161958.7208a1e2@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox